[WIP] optimize: input and textarea

bridge/core/binding_call_methods.json5

@@ -132,6 +132,8 @@
     "max",
     "minLength",
     "maxLength",
+    "selectionStart",
+    "selectionEnd",
     "size",
     "multiple",
     "name",

bridge/core/events/dart_created_events.json5

@@ -60,15 +60,15 @@
         "intersectionchange"
       ]
     },
-//    {
-//      "class": "KeyboardEvent",
-//      "types": [
-//        "keydown",
-//        "keypress",
-//        "keystatuseschange",
-//        "keyup"
-//      ]
-//    },
+    {
+      "class": "KeyboardEvent",
+      "types": [
+        "keydown",
+        "keypress",
+        "keystatuseschange",
+        "keyup"
+      ]
+    },
     "message",
 //    {
 //      "class": "PointerEvent",

bridge/core/events/keyboard_event.cc

@@ -34,24 +34,25 @@ KeyboardEvent::KeyboardEvent(ExecutingContext* context,
                              const std::shared_ptr<KeyboardEventInit>& initializer,
                              ExceptionState& exception_state)
     : UIEvent(context, type, initializer, exception_state),
-      alt_key_(initializer->hasAltKey() && initializer->altKey()),
-      char_code_(initializer->hasCharCode() ? initializer->charCode() : 0.0),
+      // alt_key_(initializer->hasAltKey() && initializer->altKey()),
+      // char_code_(initializer->hasCharCode() ? initializer->charCode() : 0.0),
       code_(initializer->hasCode() ? initializer->code() : AtomicString::Empty()),
-      ctrl_key_(initializer->hasCtrlKey() && initializer->ctrlKey()),
-      is_composing_(initializer->hasComposed() && initializer->isComposing()),
-      key_(initializer->hasKey() ? initializer->key() : AtomicString::Empty()),
-      key_code_(initializer->hasKeyCode() ? initializer->keyCode() : 0.0),
-      location_(initializer->hasLocation() ? initializer->location() : 0.0),
-      meta_key_(initializer->hasMetaKey() && initializer->metaKey()),
-      repeat_(initializer->hasRepeat() && initializer->repeat()),
-      shift_key_(initializer->hasShiftKey() && initializer->shiftKey()) {}
+      // ctrl_key_(initializer->hasCtrlKey() && initializer->ctrlKey()),
+      // is_composing_(initializer->hasComposed() && initializer->isComposing()),
+      key_(initializer->hasKey() ? initializer->key() : AtomicString::Empty())
+// key_code_(initializer->hasKeyCode() ? initializer->keyCode() : 0.0),
+// location_(initializer->hasLocation() ? initializer->location() : 0.0),
+// meta_key_(initializer->hasMetaKey() && initializer->metaKey()),
+// repeat_(initializer->hasRepeat() && initializer->repeat()),
+// shift_key_(initializer->hasShiftKey() && initializer->shiftKey())
+{}
 
 KeyboardEvent::KeyboardEvent(ExecutingContext* context,
                              const AtomicString& type,
                              NativeKeyboardEvent* native_keyboard_event)
     : UIEvent(context, type, &native_keyboard_event->native_event),
-      alt_key_(native_keyboard_event->altKey),
-      char_code_(native_keyboard_event->charCode),
+// alt_key_(native_keyboard_event->altKey),
+// char_code_(native_keyboard_event->charCode),
 #if ANDROID_32_BIT
       code_(AtomicString(
           ctx(),
@@ -65,15 +66,16 @@ KeyboardEvent::KeyboardEvent(ExecutingContext* context,
           std::unique_ptr<AutoFreeNativeString>(reinterpret_cast<AutoFreeNativeString*>(native_keyboard_event->code)))),
       key_(AtomicString(
           ctx(),
-          std::unique_ptr<AutoFreeNativeString>(reinterpret_cast<AutoFreeNativeString*>(native_keyboard_event->key)))),
+          std::unique_ptr<AutoFreeNativeString>(reinterpret_cast<AutoFreeNativeString*>(native_keyboard_event->key))))
 #endif
-      ctrl_key_(native_keyboard_event->ctrlKey),
-      is_composing_(native_keyboard_event->isComposing),
-      key_code_(native_keyboard_event->keyCode),
-      location_(native_keyboard_event->location),
-      meta_key_(native_keyboard_event->metaKey),
-      repeat_(native_keyboard_event->repeat),
-      shift_key_(native_keyboard_event->shiftKey) {
+// ctrl_key_(native_keyboard_event->ctrlKey),
+// is_composing_(native_keyboard_event->isComposing),
+// key_code_(native_keyboard_event->keyCode),
+// location_(native_keyboard_event->location),
+// meta_key_(native_keyboard_event->metaKey),
+// repeat_(native_keyboard_event->repeat),
+// shift_key_(native_keyboard_event->shiftKey)
+{
 }
 
 bool KeyboardEvent::getModifierState(const AtomicString& key_args, ExceptionState& exception_state) {

bridge/core/events/keyboard_event.d.ts

@@ -3,24 +3,25 @@ import {KeyboardEventInit} from "./keyboard_event_init";
 
 /** KeyboardEvent objects describe a user interaction with the keyboard; each event describes a single interaction between the user and a key (or combination of a key with modifier keys) on the keyboard. */
 interface KeyboardEvent extends UIEvent {
-    readonly altKey: boolean;
-    /** @deprecated */
-    readonly charCode: number;
-    readonly code: string;
-    readonly ctrlKey: boolean;
-    readonly isComposing: boolean;
+    // readonly altKey: boolean;
+    // /** @deprecated */
+    // readonly charCode: number;
     readonly key: string;
-    /** @deprecated */
-    readonly keyCode: number;
-    readonly location: number;
-    readonly metaKey: boolean;
-    readonly repeat: boolean;
-    readonly shiftKey: boolean;
-    // getModifierState(keyArg: string): boolean;
-    readonly DOM_KEY_LOCATION_LEFT: StaticMember<number>;
-    readonly DOM_KEY_LOCATION_NUMPAD: StaticMember<number>;
-    readonly DOM_KEY_LOCATION_RIGHT: StaticMember<number>;
-    readonly DOM_KEY_LOCATION_STANDARD: StaticMember<number>;
+    readonly code: string;
+    // readonly ctrlKey: boolean;
+    // readonly isComposing: boolean;
+
+    // /** @deprecated */
+    // readonly keyCode: number;
+    // readonly location: number;
+    // readonly metaKey: boolean;
+    // readonly repeat: boolean;
+    // readonly shiftKey: boolean;
+    // // getModifierState(keyArg: string): boolean;
+    // readonly DOM_KEY_LOCATION_LEFT: StaticMember<number>;
+    // readonly DOM_KEY_LOCATION_NUMPAD: StaticMember<number>;
+    // readonly DOM_KEY_LOCATION_RIGHT: StaticMember<number>;
+    // readonly DOM_KEY_LOCATION_STANDARD: StaticMember<number>;
     [key: string]: any;
 
     new(type: string, init?: KeyboardEventInit): KeyboardEvent;

bridge/core/events/keyboard_event_init.d.ts

@@ -3,17 +3,17 @@ import {UIEventInit} from "./ui_event_init";
 // @ts-ignore
 @Dictionary()
 export interface KeyboardEventInit extends UIEventInit {
-    altKey?: boolean;
-    /** @deprecated */
-    charCode?: number;
-    code?: string;
-    ctrlKey?: boolean;
-    isComposing?: boolean;
+    // altKey?: boolean;
+    // /** @deprecated */
+    // charCode?: number;
     key?: string;
-    /** @deprecated */
-    keyCode?: number;
-    location?: number;
-    metaKey?: boolean;
-    repeat?: boolean;
-    shiftKey?: boolean;
+    code?: string;
+    // ctrlKey?: boolean;
+    // isComposing?: boolean;
+    // /** @deprecated */
+    // keyCode?: number;
+    // location?: number;
+    // metaKey?: boolean;
+    // repeat?: boolean;
+    // shiftKey?: boolean;
 }

bridge/core/html/forms/html_input_element.d.ts

@@ -14,6 +14,8 @@ interface HTMLInputElement extends HTMLElement {
   max: DartImpl<string>;
   minLength: DartImpl<double>;
   maxLength: DartImpl<double>;
+  selectionStart: DartImpl<double>;
+  selectionEnd: DartImpl<double>;
   size: DartImpl<double>;
   multiple: DartImpl<boolean>;
   name: DartImpl<string>;

bridge/core/html/forms/html_textarea_element.d.ts

@@ -12,6 +12,8 @@ interface HTMLTextareaElement extends HTMLElement {
   disabled: DartImpl<boolean>;
   minLength: DartImpl<double>;
   maxLength: DartImpl<double>;
+  selectionStart: DartImpl<double>;
+  selectionEnd: DartImpl<double>;
   name: DartImpl<string>;
   placeholder: DartImpl<string>;
   readonly: DartImpl<boolean>;

bridge/include/plugin_api/keyboard_event_init.h

@@ -15,17 +15,8 @@ struct WebFKeyboardEventInit {
   double detail;
   WebFValue<Window, WindowPublicMethods> view;
   double which;
-  int32_t alt_key;
-  double char_code;
-  const char* code;
-  int32_t ctrl_key;
-  int32_t is_composing;
   const char* key;
-  double key_code;
-  double location;
-  int32_t meta_key;
-  int32_t repeat;
-  int32_t shift_key;
+  const char* code;
 };
 }  // namespace webf
 #endif  // WEBF_CORE_WEBF_API_PLUGIN_API_KEYBOARD_EVENT_INIT_H_

bridge/rusty_webf_sys/src/events/keyboard_event_init.rs

@@ -10,15 +10,6 @@ pub struct KeyboardEventInit {
   pub detail: c_double,
   pub view: RustValue<WindowRustMethods>,
   pub which: c_double,
-  pub alt_key: i32,
-  pub char_code: c_double,
-  pub code: *const c_char,
-  pub ctrl_key: i32,
-  pub is_composing: i32,
   pub key: *const c_char,
-  pub key_code: c_double,
-  pub location: c_double,
-  pub meta_key: i32,
-  pub repeat: i32,
-  pub shift_key: i32,
+  pub code: *const c_char,
 }