Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Allowed system-wide shared category #204 #293

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pandafy
Copy link
Member

@pandafy pandafy commented Feb 20, 2025

Checklist

  • I have read the OpenWISP Contributing Guidelines.
  • I have manually tested the changes proposed in this pull request.
  • I have written new test cases for new code and/or updated existing tests for changes to existing code.
  • I have updated the documentation.

Reference to Existing Issue

Closes #204

@pandafy pandafy force-pushed the issues/204-shared-firmware branch 3 times, most recently from 64318a4 to d8606e1 Compare February 21, 2025 08:16
# if DeviceFirmware instance already exists
# restrict images to the ones of the same category
if not self.instance._state.adding:
self.instance.refresh_from_db()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nemesifier I don't understand why this was present here. Do you remember?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately I don't remember..

Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a mention of shared builds and its use case in the docs, maybe quickstart?

@pandafy pandafy force-pushed the issues/204-shared-firmware branch from d8606e1 to 83747b1 Compare March 3, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Needs review
Development

Successfully merging this pull request may close these issues.

[feature] Organization-independent firmware categories
2 participants