Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: add /update/<version>/<target> call #734

Merged
merged 5 commits into from
Feb 20, 2024
Merged

Conversation

aparcar
Copy link
Member

@aparcar aparcar commented Feb 6, 2024

this call can be called by a remote process to trigger an update of a specific version/target combination, instead of requestion everything all the time. This should be a massive performance improvement and keep things better in sync.

If you enable UPDATE_TOKEN, the janitor process won't run every x minutes anymore.

For openwrt.org, this can be called via buildbots, for other projects this could be called via webhooks from just about any CI.

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 61 lines in your changes are missing coverage. Please review.

Comparison is base (2e0d279) 87.46% compared to head (9eb8179) 80.94%.

Files Patch % Lines
asu/common.py 28.57% 45 Missing ⚠️
asu/janitor.py 26.66% 11 Missing ⚠️
asu/api.py 61.53% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #734      +/-   ##
==========================================
- Coverage   87.46%   80.94%   -6.52%     
==========================================
  Files          15       15              
  Lines         973      976       +3     
==========================================
- Hits          851      790      -61     
- Misses        122      186      +64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aparcar aparcar force-pushed the update_api branch 2 times, most recently from 05d3f0f to 3bafe17 Compare February 20, 2024 15:28
 * Ruff covers both linting and formating, give it a spin
 * Python3.11 brings some handy features and this runs in containers
   anyway, make use of it

Signed-off-by: Paul Spooren <[email protected]>
Remove stuff which was never really used

Signed-off-by: Paul Spooren <[email protected]>
Added via Python 3.8

Signed-off-by: Paul Spooren <[email protected]>
This call can be called by a remote process to trigger an update of a
specific version/target combination, instead of requestion everything
all the time. This should be a massive performance improvement and keep
things better in sync.

If you enable UPDATE_TOKEN, the janitor process won't run every x
minutes anymore.

For openwrt.org, this can be called via buildbots, for other projects
this could be called via webhooks from just about any CI.

Signed-off-by: Paul Spooren <[email protected]>
@aparcar aparcar merged commit 6f634f8 into openwrt:main Feb 20, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant