Skip to content
This repository has been archived by the owner on Oct 29, 2024. It is now read-only.

Actually enable CONFIG_ZFS in builds. #228

Merged
merged 1 commit into from
May 25, 2021

Conversation

rincebrain
Copy link
Contributor

It turns out that "make proper" drops the 'CONFIG_ZFS=y' line from
.config. I couldn't readily find any documentation about why that
would be so, so I just added it later.

Tested by: Just iterating on it on my testbed until it actually worked.

Closes: #227

Signed-off-by: Rich Ercolani [email protected]

It turns out that "make proper" drops the 'CONFIG_ZFS=y' line from
.config. I couldn't readily find any documentation about why that
would be so, so I just added it later.

Closes: openzfs#227

Signed-off-by: Rich Ercolani <[email protected]>
@rincebrain
Copy link
Contributor Author

As an example illustrating the problem this is intended to solve, openzfs/zfs#12110 broke every test and buildbot...except this one.

Copy link
Contributor

@behlendorf behlendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, I'm fairly certain CONFIG_ZFS used to be preserved. Perhaps something changed in the kernel build system and we failed to notice. Either way, thanks for noticing and fix this. LGTM.

@behlendorf behlendorf merged commit 7553def into openzfs:master May 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I don't think bb-build-linux.sh actually builds ZFS in
2 participants