-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For discussion: "slack" compression option #15215
Draft
robn
wants to merge
1
commit into
openzfs:master
Choose a base branch
from
KlaraSystems:slack-compression
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,7 +18,7 @@ | |
| .\" Copyright (c) 2019, Allan Jude | ||
| .\" Copyright (c) 2021, Colm Buckley <[email protected]> | ||
| .\" | ||
| .Dd October 2, 2024 | ||
| .Dd November 18, 2024 | ||
| .Dt ZPOOL-FEATURES 7 | ||
| .Os | ||
| . | ||
|
|
@@ -932,6 +932,41 @@ preventing hash collision attacks on systems with dedup. | |
| .Pp | ||
| .checksum-spiel skein | ||
| . | ||
| .feature com.klarasystems slack_compress no extensible_dataset | ||
| .Sy slack | ||
| is a compression option that simply removes the trailing run of zero bytes at | ||
| the end of each block. | ||
| It is designed for when very large block sizes are used with to store largely | ||
| incompressible data. | ||
| Normally in this scenario | ||
| .Sy compress Ns = Ns Sy none | ||
| would be used, | ||
| but with large block sizes that can often leave a multi-megabyte run of zeroes | ||
| at the end of a block, adding memory and checksumming overhead. | ||
| .Pp | ||
| When the | ||
| .Sy slack_compress | ||
| feature is set to | ||
| .Sy enabled , | ||
| the administrator can turn on | ||
| .Sy slack | ||
| compression of any dataset using | ||
| .Nm zfs Cm set Sy compress Ns = Ns Sy slack Ar dset | ||
| .Po see Xr zfs-set 8 Pc . | ||
| This feature becomes | ||
| .Sy active | ||
| once a | ||
| .Sy compress | ||
| property has been set to | ||
| .Sy slack , | ||
| and will return to being | ||
| .Sy enabled | ||
| once all filesystems that have ever had their | ||
| .Sy compress | ||
| property set to | ||
| .Sy slack | ||
| are destroyed. | ||
| . | ||
| .feature com.delphix spacemap_histogram yes | ||
| This features allows ZFS to maintain more information about how free space | ||
| is organized within the pool. | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| /* | ||
| * CDDL HEADER START | ||
| * | ||
| * The contents of this file are subject to the terms of the | ||
| * Common Development and Distribution License (the "License"). | ||
| * You may not use this file except in compliance with the License. | ||
| * | ||
| * You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE | ||
| * or http://www.opensolaris.org/os/licensing. | ||
| * See the License for the specific language governing permissions | ||
| * and limitations under the License. | ||
| * | ||
| * When distributing Covered Code, include this CDDL HEADER in each | ||
| * file and include the License file at usr/src/OPENSOLARIS.LICENSE. | ||
| * If applicable, add the following below this CDDL HEADER, with the | ||
| * fields enclosed by brackets "[]" replaced with your own identifying | ||
| * information: Portions Copyright [yyyy] [name of copyright owner] | ||
| * | ||
| * CDDL HEADER END | ||
| */ | ||
|
|
||
| /* | ||
| * Copyright (c) 2024, Klara, Inc. | ||
| */ | ||
|
|
||
| #include <sys/zio_compress.h> | ||
| #include <sys/types.h> | ||
|
|
||
| /* | ||
| * Slack compression simply searches for the last non-zero byte in the buffer, | ||
| * and sets the position as the size of the "compressed" data. | ||
| */ | ||
|
|
||
| static size_t | ||
| zfs_slack_compress_buf(void *src, void *dst, size_t s_len, size_t d_len, | ||
| int level) | ||
| { | ||
| (void) level; | ||
|
|
||
| ASSERT3U(s_len, >, 0); | ||
| ASSERT0(P2PHASE(s_len, sizeof (uint64_t))); | ||
|
|
||
| uint64_t *buf = (uint64_t *)src; | ||
|
|
||
| int p = (s_len / sizeof (uint64_t)) - 1; | ||
| for (; p >= 0; p--) | ||
| if (buf[p] != 0) | ||
| break; | ||
|
|
||
| if (p < 0) | ||
| return (s_len); | ||
|
|
||
| size_t c_len = (p + 1) * sizeof (uint64_t); | ||
| if (c_len > d_len) | ||
| return (s_len); | ||
|
|
||
| memcpy(dst, src, c_len); | ||
| return (c_len); | ||
| } | ||
|
|
||
| static int | ||
| zfs_slack_decompress_buf(void *src, void *dst, size_t s_len, size_t d_len, | ||
| int level) | ||
| { | ||
| (void) level; | ||
| ASSERT3U(d_len, >=, s_len); | ||
| memcpy(dst, src, s_len); | ||
| if (d_len > s_len) | ||
| memset(dst+s_len, 0, d_len-s_len); | ||
| return (0); | ||
| } | ||
|
|
||
| ZFS_COMPRESS_WRAP_DECL(zfs_slack_compress) | ||
| ZFS_DECOMPRESS_WRAP_DECL(zfs_slack_decompress) | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should wipe the rest with zeroes here.