Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate some GitHub PR status labels manipulations #16721

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

amotin
Copy link
Member

@amotin amotin commented Nov 4, 2024

  • Set/remove "Work in Progress"/"Code Review Needed" for drafts.
  • Remove "Accepted", "Inactive", "Revision Needed" and "Stale" on pushes and reopens.

I hope this reduce chances of PRs being forgotten after requested modifications done due to stale labels. It is better to have no labels than incorrect ones saying there is nothing to look at.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@amotin amotin added the Status: Inactive Not being actively updated label Nov 4, 2024
@amotin amotin force-pushed the removelabels branch 2 times, most recently from 0615cba to 22c659c Compare November 4, 2024 21:17
 - Set/remove "Work in Progress"/"Code Review Needed" for drafts.
 - Remove "Accepted", "Inactive", "Revision Needed" and "Stale" on
pushes and reopens.

I hope this reduce chances of PRs being forgotten after requested
modifications done due to stale labels.  It is better to have no
labels than incorrect ones saying there is nothing to look at.

Signed-off-by:	Alexander Motin <[email protected]>
Sponsored by:	iXsystems, Inc.
@amotin amotin added Status: Code Review Needed Ready for review and testing and removed Status: Inactive Not being actively updated labels Nov 4, 2024
@amotin amotin marked this pull request as ready for review November 4, 2024 21:45
Copy link
Contributor

@behlendorf behlendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat. If we can have a workflow help manage the labels consistently so much the better. This looks reasonable to me based on the documention.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Nov 5, 2024
@amotin amotin added Status: Code Review Needed Ready for review and testing Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Accepted Ready to integrate (reviewed, tested) Status: Code Review Needed Ready for review and testing labels Nov 5, 2024
@behlendorf behlendorf merged commit 5a2333b into openzfs:master Nov 5, 2024
14 checks passed
@amotin amotin changed the title WIP: Automate some GitHub PR status labels manipulations Automate some GitHub PR status labels manipulations Nov 5, 2024
@amotin amotin deleted the removelabels branch November 5, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants