Do not copy entry in 'W' namespace when recreating zim file. #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #452 +/- ##
=======================================
Coverage 27.70% 27.70%
=======================================
Files 26 26
Lines 2534 2534
Branches 1363 1363
=======================================
Hits 702 702
Misses 1325 1325
Partials 507 507 ☔ View full report in Codecov by Sentry. |
mgautierfr
added a commit
to openzim/zim-testing-suite
that referenced
this pull request
Feb 5, 2025
Generated files are using the commands: ``` mkdir data/nov0 scripts/create_test_zimfiles --all src/small_zimfile_data/ data/nov0 zimrecreate data/withns/wikipedia_en_climate_change_mini_2024-06.zim data/nov0/wikipedia_en_climate_change_mini_2024-06.zim zimrecreate data/withns/wikibooks_be_all_nopic_2017-02.zim data/nov0/wikibooks_be_all_nopic_2017-02.zim zimsplit data/nov0/wikibooks_be_all_nopic_2017-02.zim --prefix data/nov0/wikibooks_be_all_nopic_2017-02_splitted.zim --size 51200 ``` `zimwriterfs`, `zimrecreate`, `zimsplit` are localy build using - commit b5127fc9 of libzim (commit in PR openzim/libzim#949) - commit 482a6708 of zimtools (head of PR openzim/zim-tools#452) Using non released version of libzim was necessary as we need test files to test the PR and without the PR merged, we cannot release a libzim generating such kind of files.
kelson42
force-pushed
the
recreate_exclude_w
branch
from
482a670 to
677cb58
Compare
Entries in 'W' namespace are automatically created by libzim creator. This is especially important as we will "lost" the namespace and so we would add the entry as an user entry.
kelson42
force-pushed
the
recreate_exclude_w
branch
from
677cb58 to
90a44a5
Compare
veloman-yunkan
approved these changes
Feb 10, 2025
mgautierfr
added a commit
to openzim/zim-testing-suite
that referenced
this pull request
Feb 11, 2025
Generated files are using the commands: ``` mkdir data/noTitleListingV0 scripts/create_test_zimfiles --all src/small_zimfile_data/ data/noTitleListingV0 zimrecreate data/withns/wikipedia_en_climate_change_mini_2024-06.zim data/noTitleListingV0/wikipedia_en_climate_change_mini_2024-06.zim zimrecreate data/withns/wikibooks_be_all_nopic_2017-02.zim data/noTitleListingV0/wikibooks_be_all_nopic_2017-02.zim zimsplit data/noTitleListingV0/wikibooks_be_all_nopic_2017-02.zim --prefix data/noTitleListingV0/wikibooks_be_all_nopic_2017-02_splitted.zim --size 51200 ``` `zimwriterfs`, `zimrecreate`, `zimsplit` are localy build using - commit b5127fc9 of libzim (commit in PR openzim/libzim#949) - commit 482a6708 of zimtools (head of PR openzim/zim-tools#452) Using non released version of libzim was necessary as we need test files to test the PR and without the PR merged, we cannot release a libzim generating such kind of files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Entries in 'W' namespace are automatically created by libzim creator. This is especially important as we will "lost" the namespace and so we would add the entry as an user entry.