Update ubuntu version as 20.04 is being deprecated. Fixes #2761 #2763
Conversation
|
Ubuntu Jammy has glibc 2.35. Here's some older distros. Distributions with glibc < 2.35
|
| @@ -82,7 +82,7 @@ jobs: | |||
|
|
|||
| linux-build: | |||
| name: Build Linux binaries | |||
| runs-on: ubuntu-20.04 | |||
| runs-on: ubuntu-22.04 | |||
There was a problem hiding this comment.
Should we run tests on the oldest or newest available runner? I have a preference for pinning the runner, whichever version we decide to use.
qrkourier
dismissed
dovholuknf’s stale review
we decided against requiring glibc 2.35 to run ziti
| @@ -99,7 +99,7 @@ jobs: | |||
|
|
|||
| linux-build: | |||
| name: Build Linux binaries | |||
| runs-on: ubuntu-20.04 | |||
| runs-on: ubuntu-24.04 | |||
There was a problem hiding this comment.
Why use 24.04 here, but 22.04 in the release workflow? imo it's best to build on the oldest kernel that's feasible. the resulting binaries will depend on the kernel's userspace abi (even if the build is done in a container), and care is taken to ensure that newer kernels support the abis from older kernels.
If the kernels used for the different workflows are intentionally different then it's probably worth commenting (in each workflow) why this is the case.
There was a problem hiding this comment.
OK, I'll change the PR that replaces this PR to pin the oldest available runner for jobs that build a Linux binary: #2765
|
Replaced by #2765 |
No description provided.