Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added moc infra members to owners #181

Merged
merged 1 commit into from
Feb 1, 2021

Conversation

HumairAK
Copy link
Member

As per discussion here. We are storing various cluster manifests here, so it stands to reason the environment owners should be reviewers as well.

@sesheta sesheta requested review from harshad16 and tumido January 29, 2021 16:04
@sesheta sesheta added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 29, 2021
@sesheta
Copy link
Member

sesheta commented Jan 29, 2021

The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the operate-first org. You can then trigger verification by writing /verify-owners in a comment.

  • ipolonsk
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
  • naved001
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.

@sesheta sesheta added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Jan 29, 2021
@HumairAK HumairAK requested a review from larsks January 29, 2021 16:06
@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2021
@tumido
Copy link
Member

tumido commented Jan 29, 2021

/hold

@sesheta sesheta added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 29, 2021
@anishasthana
Copy link
Member

/lgtm

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2021
@HumairAK
Copy link
Member Author

@naved001 and @ipolonsk have been invited to the org

Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@harshad16
Copy link
Member

/approve

@sesheta
Copy link
Member

sesheta commented Jan 29, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16, larsks, tumido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@harshad16
Copy link
Member

this is on hold @tumido , is this ready?

@HumairAK
Copy link
Member Author

@harshad16 this is on hold until @ipolonsk can accept the invite to the org then I'll approve

@HumairAK
Copy link
Member Author

HumairAK commented Feb 1, 2021

Everyone is in the org now
/unhold

@sesheta sesheta removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 1, 2021
@HumairAK HumairAK removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Feb 1, 2021
@HumairAK HumairAK merged commit 7fac10d into operate-first:master Feb 1, 2021
@HumairAK HumairAK deleted the update_owners branch September 16, 2021 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants