Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix whitespace generation in s3 secret #49

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Fix whitespace generation in s3 secret #49

merged 2 commits into from
Dec 18, 2023

Conversation

lukasredev
Copy link
Contributor

If you run the chart install with:
helm upgrade --create-namespace --namespace openproject --install openproject openproject/openproject --dry-run -f values.yaml

and you have defined s3 in your values.yaml:

s3:
  enabled: true
  endpoint: "minio.local"
  auth:
    existingSecret: "minio-credentials"
    secretKeys:
      accessKeyId: "accessKeyId"
      secretAccessKey: "secretAccessKey"

it fails with the following error:
Helm upgrade failed: YAML parse error on openproject/templates/secret_s3.yaml: error converting YAML to JSON: yaml: line 15: mapping values are not allowed in this context

this is due to a whitespace formatting error in secret_s3.yaml which this pull request fixes.

Copy link

changeset-bot bot commented Dec 18, 2023

🦋 Changeset detected

Latest commit: b0254db

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@openproject/helm-charts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@oliverguenther oliverguenther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I'll release this momentarily 👍

@oliverguenther oliverguenther merged commit 7511d98 into opf:main Dec 18, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants