Skip to content

Commit

Permalink
fix(lint): rubocop linting
Browse files Browse the repository at this point in the history
  • Loading branch information
as-op committed Jan 2, 2024
1 parent ead43a7 commit 06193fb
Show file tree
Hide file tree
Showing 7 changed files with 15 additions and 14 deletions.
9 changes: 9 additions & 0 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,12 @@ source "https://rubygems.org"

# dependencies are specified in md_to_pdf.gemspec
gemspec

group :development, :test do
gem 'pdf-inspector', '~> 1.3'
gem 'rake', '~> 13.1'
gem 'rspec', '~> 3.12'
gem 'rubocop', '~> 1.59'
gem 'rubocop-rake', '~> 0.6'
gem 'rubocop-rspec', '~> 2.25'
end
2 changes: 1 addition & 1 deletion lib/md_to_pdf/elements/html.rb
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ def draw_html_tag(tag, node, opts)
def find_img_caption(tag)
if tag.name == 'figure'
figcaption = tag.search("figcaption").first
return figcaption.text unless figcaption.nil?
figcaption&.text
elsif tag.parent
find_img_caption(tag.parent)
end
Expand Down
2 changes: 1 addition & 1 deletion lib/md_to_pdf/elements/list.rb
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ def list_bullet(style, is_ordered, is_task_list, number, is_checked)
end

def tasklist?(node)
!node.to_a.select { |list_item| list_item.type_string == 'tasklist' }.empty?
node.to_a.any? { |list_item| list_item.type_string == 'tasklist' }
end

def task_list_checked?(node)
Expand Down
2 changes: 1 addition & 1 deletion lib/md_to_pdf/style/helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ def opt_task_list_point_sign(style, is_checked)
end

def opt_list_point_sign(style)
((style[:sign] || '•')).to_s
(style[:sign] || '•').to_s
end

def list_point_alphabetically(int)
Expand Down
6 changes: 3 additions & 3 deletions lib/md_to_pdf/style/styles.rb
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ def hrule
end

def headline_level(level)
get_style("header_#{level}".to_sym)
get_style(:"header_#{level}")
end

def footnote_reference
Expand Down Expand Up @@ -114,15 +114,15 @@ def list(is_ordered)
end

def list_level(is_ordered, level)
get_style("#{is_ordered ? :ordered_list : :unordered_list}_#{level}".to_sym)
get_style(:"#{is_ordered ? :ordered_list : :unordered_list}_#{level}")
end

def list_point(is_ordered)
get_style(is_ordered ? :ordered_list_point : :unordered_list_point)
end

def list_point_level(is_ordered, level)
get_style("#{is_ordered ? :ordered_list : :unordered_list}_point_#{level}".to_sym)
get_style(:"#{is_ordered ? :ordered_list : :unordered_list}_point_#{level}")
end

def table
Expand Down
7 changes: 0 additions & 7 deletions md_to_pdf.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,6 @@ Gem::Specification.new do |s|
s.add_runtime_dependency "prawn-table", ["~> 0.2"]
s.add_runtime_dependency "text-hyphen", ["~> 1.5"]

s.add_development_dependency 'pdf-inspector', "~> 1.3"
s.add_development_dependency "rake", "~> 13.1"
s.add_development_dependency "rspec", "~> 3.12"
s.add_development_dependency 'rubocop', '~> 1.59'
s.add_development_dependency 'rubocop-rake', '~> 0.6'
s.add_development_dependency 'rubocop-rspec', '~> 2.25'

s.metadata['rubygems_mfa_required'] = 'true'
s.metadata["homepage_uri"] = s.homepage
s.metadata["source_code_uri"] = "https://github.com/opf/md-to-pdf"
Expand Down
1 change: 0 additions & 1 deletion spec/markdown_to_pdf/list_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -168,5 +168,4 @@
{ x: 51.81067, y: 664.152, text: "At vero eos et accusam et justo duo dolores et ea rebum. Stet clita kasd gubergren, no sea" },
{ x: 36.0, y: 650.28, text: "takimata sanctus est Lorem ipsum dolor sit amet." }])
end

end

0 comments on commit 06193fb

Please sign in to comment.