Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a loading spinner for requests #2

Merged
merged 2 commits into from
May 23, 2024
Merged

Added a loading spinner for requests #2

merged 2 commits into from
May 23, 2024

Conversation

apfohl
Copy link

@apfohl apfohl commented Jul 7, 2023

I added a loading indicator in the form of a spinner to all request making parts.

@apfohl apfohl added the enhancement New feature or request label Jul 7, 2023
@apfohl apfohl requested a review from Kharonus July 7, 2023 20:03
Copy link
Member

@Kharonus Kharonus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, I'd just like to get in a few changes.

components/printer/loading.go Outdated Show resolved Hide resolved
components/printer/loading.go Show resolved Hide resolved
components/requests/requests.go Show resolved Hide resolved
@apfohl apfohl force-pushed the loading-spinner branch from 4db54f9 to e9758fb Compare May 23, 2024 12:41
@apfohl apfohl force-pushed the loading-spinner branch from e9758fb to c8050f2 Compare May 23, 2024 12:42
@apfohl apfohl force-pushed the loading-spinner branch from 652d3e7 to 3a988bc Compare May 23, 2024 12:48
@apfohl apfohl merged commit 6645aa6 into main May 23, 2024
1 check passed
@apfohl apfohl deleted the loading-spinner branch May 23, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants