Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new icons for xeokit toolbar #48

Merged
merged 3 commits into from
Apr 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/poor-ears-begin.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@openproject/octicons': minor
---

Add icons for xeokit toolbar
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ node_modules
vendor
Gemfile.lock

# Jetbrains IDE
.idea/

# Ignore build/export artifacts
lib/**/build/

Expand Down
5 changes: 5 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,11 @@ git checkout -b <branch-name>

### 3. Add or update SVG files in the `/icons` directory

Be sure to add SVG files with the correct naming (suffix `-16` required,
suffixes `-12` and `-24` are optional). Check for the correct viewBox
inside the SVG, but do not bother with `fill`, `fill-rule`, or `clip-rule`
attributes, as those are removed by the CI step "Optimize SVGs".

### 4. Add or update keywords in `keywords.json`

```diff
Expand Down
1 change: 1 addition & 0 deletions icons/op-cursor-rectangle-select-16.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions icons/op-cursor-select-16.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions icons/op-erase-16.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions icons/op-scissors-16.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 4 additions & 0 deletions keywords.json
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,10 @@
"north-star": ["star", "snowflake", "asterisk"],
"note": ["card", "paper", "ticket"],
"octoface": ["octocat", "brand"],
"op-cursor-rectangle-select": ["group", "select"],
"op-cursor-select": ["pointer", "select", "mouse"],
"op-erase": ["remove", "delete"],
"op-scissors": ["cut", "snip", "slice", "clip"],
"organization": ["people", "group", "team"],
"package": ["box", "ship"],
"paintcan": ["style", "theme", "art", "color"],
Expand Down
Loading