Bug/59916 on narrow screens (including mobile) the view always scrolls to the activity #17617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rolling behaviour on mobile not related to activity tab discovered
…tom on mobile when in notification center
akabiru
requested changes
Jan 17, 2025
Comment on lines
+966
to
+986
| context "when on mobile screen size" do | ||
| before do | ||
| page.current_window.resize_to(500, 1000) | ||
| # simulate a mobile screen size | ||
| # the height in this spec is important as the activity tab must be visible | ||
| # otherwise the (in this case undesired) auto scrolling would not be triggered | ||
|
|
||
| wp_page.visit! | ||
| wp_page.wait_for_activity_tab | ||
| end | ||
|
|
||
| # this one is actually failing, but it's not caused by the activity tab | ||
| # the scroll position is at around 700, some other part of the frontend code seems to trigger a scroll | ||
| # happens for the files tab as well for example | ||
| # | ||
| # it "does not scroll to the bottom when the newest journal entry is on the bottom", :aggregate_failures do | ||
| # sleep 1 # wait for a potential auto scrolling to finish | ||
| # # expect activity tab not to be visibe, as the page is not scrolled to the bottom | ||
| # scroll_position = page.evaluate_script("document.querySelector(\"#content-body\").scrollTop") | ||
| # expect(scroll_position).to eq(0) | ||
| # end |
There was a problem hiding this comment.
Can we instead mark the context with an RSpec pending statement - linking to the work package to resolve this: https://community.openproject.org/work_packages/60638
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket