Do not focus custom fields in the create child dialog #17636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The field to focus is the subject field. Also test that all custom fields are displayed in the create child dialog. Also updated the `:custom_field` factory for "hierarchy" to create the root item using `CustomFields::Hierarchy::HierarchicalItemService.new` by default. A factory should not created half-baked objects.
cbliard
force-pushed
the
fix/60590-follow-up-fix-focus-on-custom-fields
branch
from
a836184 to
27a75c7
Compare
NobodysNightmare
requested changes
Jan 17, 2025
Reproduction command: rspec --seed 10236 './spec/migrations/rename_visible_to_admin_only_in_custom_fields_spec.rb[1:1:1]' './spec/models/queries/projects/project_query_custom_field_order_spec.rb[1:5:1:1]'
Refactored some methods to use `OpenProject::CustomFieldFormat` to get the `multi_value_possible` information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
PR #17625
Late review revealed an issue. This PR is a follow-up about it.
What are you trying to accomplish?
In the create child dialog, displayable from the relations tab of a work package, custom fields using the autocompleter input field are getting the focus by default. This is visible only if the work package type has some specific kind of custom fields like
hierarchy,versionorlist.This is not correct: the field to focus is the subject field.
Also add a test to ensure that all different kind of custom fields are displayed in the create child dialog and no error is reported.
What approach did you choose and why?
Pass in
focusDirectly: falseso that the focus is not stolen. This may benefit some other areas of the app.Merge checklist