added check for push event in main branch

[PrajwolAmatya]

Description

While working on this WP https://community.openproject.org/projects/revealjs/work_packages/60571/activity, there was part of code added to throw proper error message and the following check was added while deleting temporary files form temp folder:

bash~ ~if [ "$resp_code" != "204" ]; then~ ~ echo "Error: Failed to delete file $temp_filename."~ ~fi~ ~

Updated:
Actual failure occurred because the regex didn't match in the following code snippet:

commit_subject=$(git log -1 --pretty=format:%s)
  regex='Merge pull request #[0-9]+ from opf/(.+)$'
  [[ $commit_subject =~ $regex ]]

Because of this when a direct commit is pushed in the main branch it tried to delete a temporary file which does not exist resulting in the upload step to fail with following log:

filename=layout-template.pdf
+ '[' push = pull_request ']'
+ delete_temp_pdf
++ git log -1 --pretty=format:%s
+ commit_subject='check files and permissions'
+ regex='Merge pull request #[0-9]+ from opf/(.+)$'
+ [[ check files and permissions =~ Merge pull request #[0-9]+ from opf/(.+)$ ]]
Error: Process completed with exit code 1.

So, added an extra check for the github event, whether the event is an direct commit on the main branch.

[individual-it]

@as-op is the name of the main branch in all repos where this might get used main, or also master or something else?

[PrajwolAmatya]

@as-op is the name of the main branch in all repos where this might get used main, or also master or something else?

Or should we check both main and master branch?
@individual-it @as-op

[as-op]

@PrajwolAmatya @individual-it In both current use cases, it is main.
But as this might change from use case to use case, IMO would be best if this can be defined in the ENV variables, too.

[PrajwolAmatya]

I have added an env DEFAULT_BRANCH: ${{ github.event.repository.default_branch }}