removed references to deprecated python_utils file #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@athyrson06 Please follow the "getting started" instructions in the Oppia wiki https://github.com/oppia/oppia/wiki/Contributing-code-to-Oppia#setting-things-up -- we can't accept your PRs until you've done that. Once you've done that, feel free to reopen this PR if you like, and we can review it. I'm closing it for now so that it doesn't get merged accidentally. Thanks! |
|
I have now followed the steps, and I would like to request the pull request to be reopened. |
seanlip
requested changes
Nov 17, 2024
Custom-Pylint-checks.md
Outdated
| print("Hello, world!") | ||
| """) | ||
| with open(filename, 'w') as tmp: | ||
| tmp.write(""" |
There was a problem hiding this comment.
Deindent this and the following lines by 4.
|
I did the necessary adjustments now. |
seanlip
approved these changes
Nov 17, 2024
There was a problem hiding this comment.
Thanks @athyrson06, looks good! Congrats on your first Oppia PR 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Following #13935
In response to #13935, several misleading mentions and incorrect warnings were removed from the wiki. These included:
python_utilsmentions: The previous examples using onpython_utils.OBJECTand other utility functions has been updated. I’ve replaced them with standard Python constructs and best practices.strfunction: Some parts of the code were erroneously issuing warnings regarding the use of thestr()function. This warning was removed asstr()is the correct and accepted way to convert objects to strings in Python 3.Key Changes:
python_utils.OBJECTin class definitions, replacing them with standard Python class definitions.str(): The previous message warning against usingstr()was incorrect, asstr()is the appropriate way to convert to strings in Python 3.These updates help modernize the wiki, making it more in line with the new Oppia standard.