Fix #236 and #313: Remove unnecessary comment about modifications to codeowner file; notify server admins about changes to files in jobs and platform folders.

.github/workflows/frontend_tests.yml

@@ -17,7 +17,7 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions/setup-node@v3
         with:
-          node-version: '14'
+          node-version: '16'
       - name: Install dependencies
         run: npm install
       - name: Run frontend tests

constants.js

@@ -52,7 +52,6 @@ const issuesLabelCheck = 'issues-labeled-check';
 const issuesAssignedCheck = 'issues-assigned-check';
 const forcePushCheck = 'force-push-check';
 const pullRequestReviewCheck = 'pr-review-check';
-const codeOwnerCheck = 'code-owner-check';
 const ciFailureCheck = 'ci-failure-check';
 const updateWithDevelopCheck = 'update-with-develop-check';
 const respondToReviewCheck = 'respond-to-review-check';
@@ -79,7 +78,6 @@ const checksWhitelist = {
     [openEvent]: [
       assigneeCheck,
       claCheck,
-      codeOwnerCheck,
       branchCheck,
       jobCheck,
       cronJobCheck,
@@ -102,7 +100,6 @@ const checksWhitelist = {
       jobCheck,
       cronJobCheck,
       modelCheck,
-      codeOwnerCheck,
     ],
     [closeEvent]: [allMergeConflictCheck, updateWithDevelopCheck],
     [editEvent]: [wipCheck],
@@ -169,7 +166,6 @@ module.exports.hotfixLabelCheck = hotfixLabelCheck;
 module.exports.prTemplateCheck = prTemplateCheck;
 module.exports.forcePushCheck = forcePushCheck;
 module.exports.pullRequestReviewCheck = pullRequestReviewCheck;
-module.exports.codeOwnerCheck = codeOwnerCheck;
 module.exports.ciFailureCheck = ciFailureCheck;
 module.exports.updateWithDevelopCheck = updateWithDevelopCheck;
 module.exports.respondToReviewCheck = respondToReviewCheck;

index.js

@@ -32,7 +32,6 @@ const checkCriticalPullRequestModule = require(
 );
 const checkBranchPushModule = require('./lib/checkBranchPush');
 const checkPullRequestReviewModule = require('./lib/checkPullRequestReview');
-const newCodeOwnerModule = require('./lib/checkForNewCodeowner');
 const ciCheckModule = require('./lib/ciChecks');
 const periodicCheckModule = require('./lib/periodicChecks');
 
@@ -84,7 +83,8 @@ const runChecks = async (context, checkEvent) => {
             );
             break;
           case constants.jobCheck:
-            callable.push(checkPullRequestJobModule.checkForNewJob(context));
+            callable.push(
+              checkPullRequestJobModule.checkForModificationsToFiles(context));
             break;
           case constants.cronJobCheck:
             callable.push(checkCronJobModule.checkForNewCronJob(context));
@@ -132,9 +132,6 @@ const runChecks = async (context, checkEvent) => {
               checkPullRequestReviewModule.handlePullRequestReview(context)
             );
             break;
-          case constants.codeOwnerCheck:
-            callable.push(newCodeOwnerModule.checkForNewCodeowner(context));
-            break;
           case constants.ciFailureCheck:
             callable.push(ciCheckModule.handleFailure(context));
             break;

lib/checkNewCronJobs.js

@@ -17,7 +17,7 @@ const {
 } = require('../userWhitelist.json');
 const {
   DATASTORE_LABEL,
-  JOBS_AND_FETURES_TESTING_WIKI_LINK,
+  JOBS_AND_FEATURES_TESTING_WIKI_LINK,
   getAllChangedFiles,
   hasDatastoreLabel,
   pingAndAssignUsers
@@ -79,7 +79,7 @@ const getCommentBody = (changedFiles, prAuthor) => {
   const serverJobsForm = 'server jobs form'.link(
     'https://goo.gl/forms/XIj00RJ2h5L55XzU2');
   const wikiLinkText = 'this guide'.link(
-    JOBS_AND_FETURES_TESTING_WIKI_LINK);
+    JOBS_AND_FEATURES_TESTING_WIKI_LINK);
 
   const serverAdminPing = (
     'Hi @' + serverJobAdmins.join(', @') +