Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): add more tracing spans #5347

Draft
wants to merge 21 commits into
base: stable
Choose a base branch
from
Draft

Conversation

fatih-acar
Copy link
Contributor

GraphQL resolvers are useful to trace.

FragmentedPacket and others added 7 commits November 26, 2024 11:19
* Make device description a computed attribute

* Flesh out topics documentation

* Improve jinja computed attribute in schema

* Actually let's create a separated field for that

* Flesh out computed attributes guide

* Adjust computed attribute topic

* Streamline the topic page

* Polish, fixes, last touches

* Shuffle back the doc as transform isn't required for the schema to load

* Add attribute to schema

* Streamline sentence

* Added a small note about async task

* Added a line about data for the test

* Remove trailing blank space
* add a new trigger to update the git submodule (python-sdk)
@github-actions github-actions bot added the group/backend Issue related to the backend (API Server, Git Agent) label Jan 2, 2025
Copy link

codspeed-hq bot commented Jan 2, 2025

CodSpeed Performance Report

Merging #5347 will not alter performance

Comparing fac-more-spans (e47b1e0) with stable (b3fa9b0)

Summary

✅ 11 untouched benchmarks

wartraxx51 and others added 10 commits January 3, 2025 10:52
* update copy buttons

* remove id in details list

* get description from object instead of schema if possible

* add fragment

* update mock data

* fix hfid

* fix component check

* update tests

* update test

* change the details button to keep the help button as it is

* update fragment

* update hfid copied value
* update copy buttons

* remove id in details list

* get description from object instead of schema if possible

* add fragment

* update mock data

* fix hfid

* fix component check

* update tests

* update test

* change the details button to keep the help button as it is

* update fragment

* update node select for filters

* update hfid copied value

* update name select component

* update task filter for node

* lint

* add fragment
GraphQL resolvers are useful to trace.

Signed-off-by: Fatih Acar <[email protected]>
Signed-off-by: Fatih Acar <[email protected]>
@github-actions github-actions bot added group/frontend Issue related to the frontend (React) group/ci Issue related to the CI pipeline labels Jan 7, 2025
We can avoid an extra generate_object_types() call by running
get_gql_query() earlier.

Signed-off-by: Fatih Acar <[email protected]>
There is a few microseconds overhead for this function...
Also add a span for Query.execute in order to know the overhead of
fetching the results.

Signed-off-by: Fatih Acar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
group/backend Issue related to the backend (API Server, Git Agent) group/ci Issue related to the CI pipeline group/frontend Issue related to the frontend (React)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants