-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(backend): add more tracing spans #5347
Draft
fatih-acar
wants to merge
21
commits into
stable
Choose a base branch
from
fac-more-spans
base: stable
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+10,361
−610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make device description a computed attribute * Flesh out topics documentation * Improve jinja computed attribute in schema * Actually let's create a separated field for that * Flesh out computed attributes guide * Adjust computed attribute topic * Streamline the topic page * Polish, fixes, last touches * Shuffle back the doc as transform isn't required for the schema to load * Add attribute to schema * Streamline sentence * Added a small note about async task * Added a line about data for the test * Remove trailing blank space
* add a new trigger to update the git submodule (python-sdk)
Merge Stable (1.1.0) into develop
github-actions
bot
added
the
group/backend
Issue related to the backend (API Server, Git Agent)
label
Jan 2, 2025
fatih-acar
force-pushed
the
fac-more-spans
branch
from
January 2, 2025 07:48
f53b921
to
e47b1e0
Compare
CodSpeed Performance ReportMerging #5347 will not alter performanceComparing Summary
|
dgarros
approved these changes
Jan 2, 2025
* update copy buttons * remove id in details list * get description from object instead of schema if possible * add fragment * update mock data * fix hfid * fix component check * update tests * update test * change the details button to keep the help button as it is * update fragment * update hfid copied value
* update copy buttons * remove id in details list * get description from object instead of schema if possible * add fragment * update mock data * fix hfid * fix component check * update tests * update test * change the details button to keep the help button as it is * update fragment * update node select for filters * update hfid copied value * update name select component * update task filter for node * lint * add fragment
Merge back stable into develop (1.1.1)
GraphQL resolvers are useful to trace. Signed-off-by: Fatih Acar <[email protected]>
Signed-off-by: Fatih Acar <[email protected]>
fatih-acar
force-pushed
the
fac-more-spans
branch
from
January 7, 2025 12:59
e47b1e0
to
41f865e
Compare
github-actions
bot
added
group/frontend
Issue related to the frontend (React)
group/ci
Issue related to the CI pipeline
labels
Jan 7, 2025
Signed-off-by: Fatih Acar <[email protected]>
We can avoid an extra generate_object_types() call by running get_gql_query() earlier. Signed-off-by: Fatih Acar <[email protected]>
There is a few microseconds overhead for this function... Also add a span for Query.execute in order to know the overhead of fetching the results. Signed-off-by: Fatih Acar <[email protected]>
Signed-off-by: Fatih Acar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
group/backend
Issue related to the backend (API Server, Git Agent)
group/ci
Issue related to the CI pipeline
group/frontend
Issue related to the frontend (React)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GraphQL resolvers are useful to trace.