Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement security tips page #133

Merged
merged 1 commit into from
Mar 23, 2020
Merged

Implement security tips page #133

merged 1 commit into from
Mar 23, 2020

Conversation

florianschmidt1994
Copy link
Member

What changes does this PR introduce
This introduces the page /#/security-tips and refactors the 4 tips into a separate component.

Part of #122

Checklist

  • yarn build passes
  • yarn lint does not show any errors

Others details

  • This PR introduces a new dependency. Reason: Mention your reason for introducing this dependency here

localhost_3000_ (1)

If you have any questions be sure to let us know! For review ping anyone in this list:

tgraupne
tgraupne approved these changes Mar 23, 2020
View reviewed changes
Copy link
Member

@tgraupne tgraupne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tgraupne tgraupne merged commit ff5c379 into develop Mar 23, 2020
@tgraupne tgraupne deleted the security-notices branch March 23, 2020 21:24
@tgraupne tgraupne linked an issue Mar 23, 2020 that may be closed by this pull request
Redesign desktop navigation #122
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgraupne tgraupne tgraupne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redesign desktop navigation
2 participants
@florianschmidt1994 @tgraupne