Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/205 failing build use effect dependencies #209

Merged
merged 6 commits into from
Apr 6, 2020
Merged

Fix/205 failing build use effect dependencies #209

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f0c83a7
disable linter for exhaustive-deps rule on useEffect
Apr 5, 2020
cf1a57b
add missing dependency
Apr 5, 2020
3461d66
remove conosle.log
Apr 5, 2020
556d3dd
fix assets imports
Apr 5, 2020
27c771c
add react-hooks plugin
Apr 5, 2020
73fb7d9
disable exhaustive-deps linting rule for useEffect
Apr 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@
"sourceType": "module"
},
"plugins": [
"react"
"react",
"react-hooks"
],
"rules": {
"max-len": "off",
Expand All @@ -39,4 +40,4 @@
"jsx-a11y/click-events-have-key-events": "off",
"jsx-a11y/no-static-element-interactions": "off"
}
}
}
4 changes: 3 additions & 1 deletion src/components/FilteredList.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,9 @@ export default function FilteredList(props) {

useEffect(() => {
loadDocuments(buildQuery());
}, []);
},
// eslint-disable-next-line react-hooks/exhaustive-deps
[]);

const handleChange = (address) => {
setLocation(address);
Expand Down
8 changes: 4 additions & 4 deletions src/components/entry/Entry.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,9 +191,9 @@ export default function Entry(props) {
if (!reported && !prevValue) document.body.addEventListener('click', clearReportAttempt);
}}
>
{reported ? <img className="flag" src={require('../assets/flag_orange.svg')} alt="" /> : null}
{!reported && !attemptingToReport ? <img className="flag" src={require('../assets/flag_red.svg')} alt="" /> : null}
{!reported && attemptingToReport ? <img className="cross" src={require('../assets/x.svg')} alt="" /> : null}
{reported ? <img className="flag" src={require('../../assets/flag_orange.svg')} alt="" /> : null}
{!reported && !attemptingToReport ? <img className="flag" src={require('../../assets/flag_red.svg')} alt="" /> : null}
{!reported && attemptingToReport ? <img className="cross" src={require('../../assets/x.svg')} alt="" /> : null}
</button>
) : null}
{attemptingToReport
Expand All @@ -211,7 +211,7 @@ export default function Entry(props) {
onClick={reportEntry}
>
Post melden?
<img className="ml-2 inline-block" src={require('../assets/flag_white.svg')} alt="" />
<img className="ml-2 inline-block" src={require('../../assets/flag_white.svg')} alt="" />
</button>
</div>
) : null}
Expand Down
2 changes: 1 addition & 1 deletion src/views/CompleteOfferHelp.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ export default function CompleteOfferHelp() {
}

completeSignup();
}, []);
}, [t]);

return (
<div className="p-4">
Expand Down
1 change: 0 additions & 1 deletion src/views/Press.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ export default function Press() {
const [presseLink, errorGeneratingPressLink] = useFirebaseDownload('gs://quarantine-hero-assets/MarketingKit.zip', firebase);

if (errorGeneratingPressLink) {
console.error('Could not generate press link', errorGeneratingPressLink);
Sentry.captureException(errorGeneratingPressLink);
}

Expand Down