Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WMS ID: #11821 ATOM Multi Agent Chatbot - Adding new livelab #366

Merged
merged 138 commits into from
Jan 29, 2025

Conversation

abhinavoracle
Copy link
Contributor

WMS ID: #11821 ATOM Multi Agent Chatbot

General requirements

  1. Information in the workshop is adequate and updated
  2. Code is correct and working
  3. Links are correct
  4. Make sure you enter the help email link in your manifest.json
  5. Please make sure WMS URLs are updated as needed after your PR is approved

Checklist - Refer to the QA document for the complete list

Please confirm that the following is completed before submitting your PR

  • All filenames are lower case (including folders, images, files, etc.)
  • Filenames are descriptive
  • Your workshop folder structure should be similar to the one used in the sample workshop (https://github.com/oracle-livelabs/common/tree/main/sample-livelabs-templates/sample-workshop)
  • Are you using multiple versions (desktop/, sandbox/, tenancy/)? Make sure that each of them contains a manifest.json and an index.html
  • Image references in markdown contain an alternate text

Copy link

@carmenberdant1 carmenberdant1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @abhinavoracle, a few things I noticed:

  • the images from the provision-agent-os file are not displaying properly.
  • some images in the provision-oic-service file have private information showing
    I'll dm you as well for clarification.

@abhinavoracle
Copy link
Contributor Author

All the requested changes have been made. Kindly approve the PR. Thank you!

@carmenberdant1 carmenberdant1 merged commit 71ed1e1 into oracle-livelabs:main Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants