Bugfix/orders db init failure #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterj
approved these changes
Jul 13, 2020
junior
approved these changes
Jul 13, 2020
| {{- define "orders.mount.init.wallet" -}} | ||
| # for init container | ||
| - name: wallet | ||
| mountPath: /usr/lib/oracle/19.3/client64/lib/network/admin/ |
There was a problem hiding this comment.
This is a workaround. We should review to fix the issue #138
tqumhieh
approved these changes
Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bug for the orders DB initialization failing when manually setting up ATP.
The root cause of the issue is that #169 changed the way TNS configuration was done. The goal was to remove the dependency on the instant client version from everywhere except application build (build.gradle/pom.xml). However the change did not account for the fact that the the DB init job uses the instant client, which still expects the old configuration.
This PR effectively creates a
mountfor the same wallet secret for the DB tools container, but mounted on the path that the location it expects. Alternatively it should be sufficient to set theTNS_ADMINenv var for thedbtoolscontainer, however, it does not seem to respect an alternateTNS_ADMIN