Fix docker version check to remove the OS identifier from the version #2772
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
OracleDatabase/SingleInstance/dockerfiles/buildContainerImage.sh
I noted the following error:On investigation I discovered that
docker version --format '{{.Server.Version }}'
now includes an operating system identifier, e.g.-ol
, which makes the current-lt
test fail as it expects to compare integers.This pull request includes a commit to remove the operating system identifier from the docker version, if present.
I've also taken the opportunity the clean up trailing and inconsistent whitespace in the file.
For references my environment is: