Implements Permalinking #19
Conversation
Adds version query paramter to use commit SHAs of `gh-pages` branch for fetching `summary.json` Signed-off-by: sswastik02 <[email protected]>
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
oracle-contributor-agreement
bot
added
the
OCA Required
|
Thank you for signing the OCA. |
oracle-contributor-agreement
bot
added
OCA Verified
|
@brenns10, Please do let me know if any changes are necessary. |
There was a problem hiding this comment.
This is a really excellent first step, thank you for this! I've added some comments below, the main items are that we should express the versions to the user in terms of date (i.e. commit date), not SHA. And the default version should be the most recent one, i.e. the current gh-pages branch. With fixes for that, I'll merge it.
Again, thanks!
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA). To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
oracle-contributor-agreement
bot
added
OCA Required
|
No need to credit me in commits, this is all part of code review, it is your work! (But if you do mention me, the Oracle bot will yell unless you use my oracle email address: [email protected]) |
|
Thank you for signing the OCA. |
oracle-contributor-agreement
bot
added
OCA Verified
Adds Button to choose version of website Adds modal for selector of version Signed-off-by: sswastik02 <[email protected]>
sswastik02
force-pushed
the
main
branch
2 times, most recently
from
102cced to
4597fc8
Compare
Modifies `updateVersion` function to return "gh-pages" when no version is present. Modifies `updateVersion` function to reload page when wrong version is present. Co-authored-by: Stephen Brennan <[email protected]> Signed-off-by: sswastik02 <[email protected]>
Adds a date picker using Bootstrap Date Picker and uses a version date mapping to redirect to right version after choosing date Signed-off-by: sswastik02 <[email protected]>
|
@brenns10, I have made the required changes, please do let me know if they are ok. |
There was a problem hiding this comment.
@sswastik02 this is great! I pulled it down to test it locally, and I did encounter two small issues. However, I found that it was a bit easier to tweak it a bit myself to resolve them. So what I'm doing is merging this as-is, and then I'll add a commit on top of this which adds some tiny tweaks. Thank you for this great contribution!
|
Here are the very minor tweaks I ended up making: b367512 |
Adds UI Element to choose version
Adds version handling in
index.htmlCloses #8