Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Comparable to the CubicPopulators in order to make an orderable generation && caching Heightmaps in order to use on another generators #81

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

z3nth10n
Copy link

@z3nth10n z3nth10n commented Apr 6, 2020

Added Comparable to the ICubicPopulators; changed HashSet --> TreeSet on EarthTerrainProcessor; added line to .gitignore; created method to check if the current cube is a road cube

I need it to check for the cubes that generates roads on my Lost Cities port:

https://github.com/uta-org/LostCities-Patched

Also, I realized that the .gitignore file needed to exclude a "logs" folder that it was created when a new MC instance is created.

@z3nth10n z3nth10n changed the title Added Comparable to the CubicPopulators in order to make an orderable generation Added Comparable to the CubicPopulators in order to make an orderable generation && caching Heightmaps in order to use on another generators Apr 7, 2020
@orangeadam3
Copy link
Owner

Uhhh.... mabye. I think a list would accomplish just as much as a comparable set would, and caching might slow evreything down, the ( It would be nice not to have to estimate surfaces, but not evrey saved chunk is necessarily populated )

@z3nth10n
Copy link
Author

z3nth10n commented Apr 8, 2020

Catching could be removed later, just as an idea, but it's required for any other mod that requires the heightmaps. (Is slower guessing the height or getting the surface blocks for every block)

… on EarthTerrainProcessor; added line to .gitignore; created method to check if the current cube is a road cube
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants