-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize lexers #130
Modernize lexers #130
Conversation
e15726e
to
baa8d45
Compare
I appreciate your zeal on this initiative, but it's not as simple as it seems. I could write a script to follow the migration steps mentioned in #76, but that's not the point. As mentioned in that issue's description, this is an opportunity to:
Also, we should see if any word lists need to be added or updated, or if the language has added new features the lexer doesn't support. I imagine for each lexer this will require research and careful thought. I don't feel that there is a point in applying the migration steps just for the sake of doing so because (1) it's just busy work, and (2) these legacy lexers still function properly. I'd like to think that a migrated lexer is complete and current for its language. That said, I will not try and dissuade you from this task :) Just please keep in mind there are criteria I have for acceptance. |
I understand that such mass change will never make the perfect results, but I believe that it is better to do this yes largely a busy work (not only, I do overview each lexer, and some of them are substantially improved, like my |
4306261
to
b0e8267
Compare
References: orbitalquark#76
References: orbitalquark#76
References: orbitalquark#76
References: orbitalquark#76
I will rather split into individual PRs, easier to review. |
Partially fixes: #76
Will add more fixes to this branch, help (and PRs to my repo) is more than welcome!
(@orbitalquark , feel free to partially merge commits in this PR, but please don’t close it yet, I will happily rebase on the current
default
and continue with more lexers).