PorcE: Add TODOs for issue #216.

orc-lang · Oct 10, 2017 · 66d9130 · 66d9130
1 parent 5476426
commit 66d9130
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 0 deletions.
diff --git a/PorcE/src/orc/run/porce/GetField.java b/PorcE/src/orc/run/porce/GetField.java
@@ -41,6 +41,7 @@ public Object slowPath(final Object obj) {
             return accessWithBoundary(accessor, obj);
         } catch (final Exception e) {
             CompilerDirectives.transferToInterpreter();
+			// TODO: Wrap exception to include Orc stack information. This will mean wrapping this in JavaException if needed and calling setBacktrace
             execution.get().notifyOrcWithBoundary(new CaughtEvent(e));
             throw HaltException.SINGLETON();
         }

diff --git a/PorcE/src/orc/run/porce/call/ExternalCPSDispatch.java b/PorcE/src/orc/run/porce/call/ExternalCPSDispatch.java
@@ -82,13 +82,15 @@ public void specificDirect(final VirtualFrame frame, final Object target, final
 			throw e;
 		} catch (final ExceptionHaltException e) {
 			exceptionProfiles[0].enter();
+			// TODO: Wrap exception to include Orc stack information. This will mean wrapping this in JavaException if needed and calling setBacktrace
 			execution.get().notifyOrcWithBoundary(new CaughtEvent(e.getCause()));
 			counter.haltToken();
 		} catch (final HaltException e) {
 			exceptionProfiles[1].enter();
 			counter.haltToken();
 		} catch (final Exception e) {
 			exceptionProfiles[2].enter();
+			// TODO: Wrap exception to include Orc stack information. This will mean wrapping this in JavaException if needed and calling setBacktrace
 			execution.get().notifyOrcWithBoundary(new CaughtEvent(e));
 			counter.haltToken();
 		}
@@ -116,13 +118,15 @@ public void specific(final VirtualFrame frame, final Object target, final Object
 			throw e;
 		} catch (final ExceptionHaltException e) {
 			exceptionProfiles[0].enter();
+			// TODO: Wrap exception to include Orc stack information. This will mean wrapping this in JavaException if needed and calling setBacktrace
 			execution.get().notifyOrcWithBoundary(new CaughtEvent(e.getCause()));
 			counter.haltToken();
 		} catch (final HaltException e) {
 			exceptionProfiles[1].enter();
 			counter.haltToken();
 		} catch (final Exception e) {
 			exceptionProfiles[2].enter();
+			// TODO: Wrap exception to include Orc stack information. This will mean wrapping this in JavaException if needed and calling setBacktrace
 			execution.get().notifyOrcWithBoundary(new CaughtEvent(e));
 			counter.haltToken();
 		}

diff --git a/PorcE/src/orc/run/porce/call/ExternalDirectDispatch.java b/PorcE/src/orc/run/porce/call/ExternalDirectDispatch.java
@@ -39,13 +39,15 @@ public Object specific(final VirtualFrame frame, final Object target, final Obje
 			return invokeDirectWithBoundary(invoker, target, arguments);
 		} catch (final ExceptionHaltException e) {
 			exceptionProfiles[0].enter();
+			// TODO: Wrap exception to include Orc stack information. This will mean wrapping this in JavaException if needed and calling setBacktrace
 			execution.get().notifyOrcWithBoundary(new CaughtEvent(e.getCause()));
 			throw HaltException.SINGLETON();
 		} catch (final HaltException e) {
 			exceptionProfiles[1].enter();
 			throw e;
 		} catch (final Exception e) {
 			exceptionProfiles[2].enter();
+			// TODO: Wrap exception to include Orc stack information. This will mean wrapping this in JavaException if needed and calling setBacktrace
 			execution.get().notifyOrcWithBoundary(new CaughtEvent(e));
 			throw HaltException.SINGLETON();
 		}
@@ -58,13 +60,15 @@ public Object universal(final VirtualFrame frame, final Object target, final Obj
 			return invokeDirectWithBoundary(invoker, target, arguments);
 		} catch (final ExceptionHaltException e) {
 			exceptionProfiles[0].enter();
+			// TODO: Wrap exception to include Orc stack information. This will mean wrapping this in JavaException if needed and calling setBacktrace
 			execution.get().notifyOrcWithBoundary(new CaughtEvent(e.getCause()));
 			throw HaltException.SINGLETON();
 		} catch (final HaltException e) {
 			exceptionProfiles[1].enter();
 			throw e;
 		} catch (final Exception e) {
 			exceptionProfiles[2].enter();
+			// TODO: Wrap exception to include Orc stack information. This will mean wrapping this in JavaException if needed and calling setBacktrace
 			execution.get().notifyOrcWithBoundary(new CaughtEvent(e));
 			throw HaltException.SINGLETON();
 		}