Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade all dependencies #802

Merged
merged 4 commits into from
Nov 15, 2024
Merged

Conversation

nwalters512
Copy link
Contributor

@nwalters512 nwalters512 commented Nov 15, 2024

This bumps all dependencies to their latest versions.

The only one I couldn't upgrade was chai. We use Karma's frameworks option to make it available on the client, but it seems like Karma doesn't yet know how to load ESM packages, and chai v5 is now ESM-only. Possibly relevant:

Comment on lines -13 to -16
],
"plugins": [
["@babel/plugin-transform-class-properties", { "loose": true }]
]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer necessary; @babel/preset-env does this automatically now.

"scss/dollar-variable-pattern": null,
"color-function-notation": "legacy",
"scss/at-import-partial-extension": null
"scss/load-partial-extension": null,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scss/at-import-partial-extension was deprecated in favor of this new rule.

"selector-class-pattern": null,
"scss/no-global-function-names": null,
"shorthand-property-no-redundant-values": null,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually like the long form that we use in a few places, so I opted to disable this.

Comment on lines -1 to -3
#!/bin/sh
. "$(dirname "$0")/_/husky.sh"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Necessary for Husky v9.

@@ -126,7 +125,7 @@
"test:types": "attw --pack --profile node16 .",
"start": "grunt serve",
"pretest": "grunt build",
"prepare": "husky install",
"prepare": "husky",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Necessary for Husky v9.

@nwalters512 nwalters512 merged commit b87d4c1 into master Nov 15, 2024
3 checks passed
@nwalters512 nwalters512 deleted the upgrade-dependencies-2024-11-15 branch November 15, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant