-
-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade all dependencies #802
Conversation
], | ||
"plugins": [ | ||
["@babel/plugin-transform-class-properties", { "loose": true }] | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is no longer necessary; @babel/preset-env
does this automatically now.
"scss/dollar-variable-pattern": null, | ||
"color-function-notation": "legacy", | ||
"scss/at-import-partial-extension": null | ||
"scss/load-partial-extension": null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scss/at-import-partial-extension
was deprecated in favor of this new rule.
"selector-class-pattern": null, | ||
"scss/no-global-function-names": null, | ||
"shorthand-property-no-redundant-values": null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually like the long form that we use in a few places, so I opted to disable this.
#!/bin/sh | ||
. "$(dirname "$0")/_/husky.sh" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Necessary for Husky v9.
@@ -126,7 +125,7 @@ | |||
"test:types": "attw --pack --profile node16 .", | |||
"start": "grunt serve", | |||
"pretest": "grunt build", | |||
"prepare": "husky install", | |||
"prepare": "husky", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Necessary for Husky v9.
This bumps all dependencies to their latest versions.
The only one I couldn't upgrade was
chai
. We use Karma'sframeworks
option to make it available on the client, but it seems like Karma doesn't yet know how to load ESM packages, andchai
v5 is now ESM-only. Possibly relevant: