Added activeAccordion method to Accordion.php #2939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tabuna
reviewed
Jan 23, 2025
| ? array_merge($this->variables['open'], Arr::wrap($activeAccordion)) | ||
| : $activeAccordion; | ||
|
|
||
| $this->openSet = true; |
There was a problem hiding this comment.
What is the purpose of the openSet property in our case?
There was a problem hiding this comment.
When creating a class, we set a standard key for the first tab in the constructor to preserve the standard previous behavior.
A flag property is needed so that when the method is first called, it can be distinguished whether it was called earlier and, depending on this, merge the array or overwrite it.
tabuna
reviewed
Jan 23, 2025
| /** | ||
| * @var array | ||
| */ | ||
| protected $variables = [ | ||
| 'stayOpen' => false, | ||
| 'open' => [], |
There was a problem hiding this comment.
Maybe we should aim for more consistency with naming? Since we're calling the method active*, perhaps it would make sense to also use the key as active.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Proposed Changes