Replacing #define with strongly typed enum #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Make sense too me. Indeed this breaks backwards compatibility, but this seems to be minor, and BFL hasn't reached version 1.x ;-) |
|
Hi Kunal, see above, what do you think about SampleMthd as compromise name? |
|
Sure. That works. I don't know why the notification didn't appear. I'll update it soon when I get to my workstation. |
* master: scythe no longer developed nor maintained upstream LTIlib no longer developed nor maintained upstream, part 2 LTIlib no longer developed nor maintained upstream fix issue orocos#45 - Using GNUInstallDirs. Thx Josch fix issue orocos#42 (test fails on i386 architecture). Patch provided by josch small attempt to make README.md a little more accurate fix issue orocos#4 : error in the tests fix typo in header guard fix doxygen typo: discreteConditionalPdf is not an abstract class Removed executable file permissions from pdf/mixture.{cpp,h}
toeklk
approved these changes
May 24, 2018
|
Thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31 and #30 (somewhat) in the sense that an external
#define DEFAULTwould still cause an issue (pre-processor is dumb) , nothing we can do about it.But we use enumerator now, better than
static const intfor type safety.This would break a lot of people's setup so we should ideally communicate this to them somehow.
Additional test failure reported with Eigen matrix library (#2)
Breaks a lot of personal code styling guides 😄
PS: Open for better name as compared to
Sampling.SamplingMethodis just a bit too long,SmpMthdis too cryptic...