block/035: Test shared queue fairness

[bvanassche]

No description provided.

[bvanassche]

@kawasaki Do you get notified automatically if a pull request is created or do we perhaps have to ping you?

[kawasaki]

@kawasaki Do you get notified automatically if a pull request is created or do we perhaps have to ping you?

@bvanassche Sorry, I missed this pull request in last four days since I was busy on zbd/010 and nbd/002 failures. I made it my daily routine to check my GitHub notification page, but this is the "pull" style then I tend to miss it. I have set up GitHub notification to come to my e-mail reader so that I can receive the notifications in "push" style. I hope it will reduce the chance to miss.

Will look into your pull requests today. Thanks.

[kawasaki]

I noticed that this PR adds the test case to confirm no regression by the patch proposed to linux-block.

[kawasaki]

This test case looks interesting and valuable. Please find my comments. Also, could you add a brief comment in the commit message? Thanks.

[kawasaki]

@bvanassche Thank you for updating the commit. I did trial runs and results look good. I would like to clarify one point before merge. Please find the question I made.

[kawasaki]

Thank you @bvanassche for the update. This PR has got merged.

After that, I came up with an idea to print the IOPS numbers so that we can check them easier.

diff --git a/tests/block/035 b/tests/block/035
index 7669633..f9267dd 100755
--- a/tests/block/035
+++ b/tests/block/035
@@ -73,6 +73,8 @@ test() {
        local iops1 iops2 rest
        read -r iops1 iops2 rest \
             <<<"$(sed -n 's/.*IOPS=\([0-9]*\).*/\1/p' <"${fio_output}" | xargs)"
+       TEST_RUN["  1 ms completion IOPS"]=$iops1
+       TEST_RUN["100 ms completion IOPS"]=$iops2
        if [ -z "$iops1" ] || [ -z "$iops2" ] ||
                        [ "$iops1" -lt "$iops2" ]; then
                echo "Error: IOPS too low ($iops1; $iops2)"

The two lines change will makes the blktests run output as follows:

block/035 (shared tag set fairness)                          [passed]
        100 ms completion IOPS  318      ...  318
          1 ms completion IOPS  27000    ...  27194
        runtime                 31.076s  ...  31.063s

I may post this patch later when I have time to afford.