build: integrate prepare source from composer

[lzap]

I noticed this automated PR failed:

#1475

This is a chance to integrate changes from composer which uses a new Go feature "toolbox", hopefully it will prevent from automated failures.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

[lzap]

Hey @croissanne and @ezr-ondrej this needs an attention - other PRs are failing because of a version requirement, I believe it is great time to fix prepare sources for once.

There is a tread on #osbuild channel about this, this was merged into composer, then reverted by @achilleas-k and now the final version is heading in: osbuild/osbuild-composer#4600 also being integrated elsewhere: osbuild/weldr-client#155

[lzap]

The TOOLS_PATH will disappear once we upgrade to 1.24 which features the all new Go tool pinning feature. In short, external tools will be added to go.mod now ensuring we all are on the same version. Until then, this is I believe a good workaround for the time being.

[ezr-ondrej]

Works for me, one nit, apart of that it works... and if it works, merge it 😛

[ezr-ondrej]

This doesn't work, I see the WARNING even tho we are on latest, I believe the issue is:

Suggested change

	if test "$LATEST" != "go$GO_VERSION"; then
	if test "$LATEST" != "$GO_VERSION"; then

[lzap]

Right, rebased.

[ezr-ondrej]

Sorry I wasn't fast enough and there is conflict now :/

[lzap]

Sorry I wasn't fast enough and there is conflict now :/

This is fine, the other patch was more important it fixed a CICD problem. Rebased.

[ezr-ondrej]

The Checks CI fails with following error, I'm not sure what it's trying to tell me :)

jsonschema: "run" does not validate with "/properties/run/additionalProperties": additional properties 'skip-dirs' not allowed
jsonschema: "" does not validate with "/additionalProperties": additional properties 'exclude-dirs' not allowed
Failed executing command with error: the configuration contains invalid elements

[lzap]

Fixed, this can be dropped from the linter config as vendor/ was dropped from this repository.

Also integrating #1484 update into this PR as well.

[ezr-ondrej]

Hmm container test is trying to build an container and fails
go: go.mod requires go >= 1.22.12 (running go 1.22.9; GOTOOLCHAIN=local) go-toolset seems to be on 1.22.9 :/

[lzap]

Yeah the warning I implemented is sort of useless since Go Toolset in RHEL is few versions behind usually. But we now have the working in composer to so let's stick with it? Rebased.

[ezr-ondrej]

/retest

[ezr-ondrej]

The failures feel unrelated 🤔
Lets discuss this with osbuild QE tomorrow :)

[ezr-ondrej]

or @tkoscieln once you get to this, do you know what's going on here? 🤔

#tests.test_blueprints.test_blueprint_details[ViaREST] (from pytest)

>       assert expected_values["customizations"] == blueprint_details["customizations"]
E       AssertionError: assert {'filesystem': [{'min_size': 5368709120, 'mountpoint': '/home'}, {'min_size': 1572864000, 'mountpoint': '/var/log'}], 'packages': ['bash'], 'payload_repositories': []} == {'filesystem': [{'min_size': 5368709120, 'mountpoint': '/home'}, {'min_size': 1572864000, 'mountpoint': '/var/log'}], 'hostname': '', 'locale': {}, 'packages': ['bash'], 'payload_repositories': [], 'timezone': {}}

[lzap]

Ephemeral failure. /retest

[tkoscieln]

@ezr-ondrej hello, this is my mistake and I know exactly what broke here. I accidentally forgot to push one commit before merging new changes to our plugin yesterday, @lzap the missing commit is a fix for the issues I had with what API returns that we discussed last week. Will fix this asap.

[tkoscieln]

@ezr-ondrej @lzap sorry for the delay, was facing some errors from Quay during the IQE container push. Should be fixed now.
/retest