Skip to content

Commit

Permalink
add decision document on source maps
Browse files Browse the repository at this point in the history
  • Loading branch information
kentcdodds committed Nov 3, 2023
1 parent cc20e62 commit 7d135a3
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 1 deletion.
2 changes: 1 addition & 1 deletion docs/decisions/016-source-maps.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

Date: 2023-06-14

Status: accepted
Status: superseded by [034-source-maps](034-source-maps.md)

## Context

Expand Down
24 changes: 24 additions & 0 deletions docs/decisions/034-source-maps.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
# Source Maps

Date: 2023-11-03

Status: accepted

## Context

Read [016-source-maps](016-source-maps.md) to come up to speed on the context.

Because of our built-in sentry support, we need to generate source maps, but we
do not necessarily need to ship source maps to the client. Despite the arguments
made in the original source map decision document, the benefit of shipping
source maps over not shipping them is reduced thanks to Sentry. And the dangers
are still present.

## Decision

Delete source maps after they've been uploaded to Sentry.

## Consequences

This will mean debugging a production application in the client will be really
hard, but with Sentry properly configured it should definitely not be a problem.

0 comments on commit 7d135a3

Please sign in to comment.