Core/Updater: Fix gcc warning

osleyder85 · May 5, 2024 · b288fce · b288fce
1 parent e7c0ea9
commit b288fce
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/server/database/Updater/UpdateFetcher.cpp b/src/server/database/Updater/UpdateFetcher.cpp
@@ -412,7 +412,7 @@ void UpdateFetcher::CleanUp(AppliedFileStorage const& storage) const
 
 void UpdateFetcher::UpdateState(std::string const& name, State const state) const
 {
-    std::string const update = "UPDATE `updates` SET `state`=\'" + AppliedFileEntry::StateConvert(state) + "\' WHERE `name`=\"" + name + "\"";
+    std::string const update = Trinity::StringFormat(R"(UPDATE `updates` SET `state`='{}' WHERE `name`="{}")", AppliedFileEntry::StateConvert(state), name);
 
     // Update database
     _apply(update);

diff --git a/src/server/database/Updater/UpdateFetcher.h b/src/server/database/Updater/UpdateFetcher.h
@@ -86,12 +86,12 @@ class TC_DATABASE_API UpdateFetcher
 
         uint64 const timestamp;
 
-        static inline State StateConvert(std::string const& state)
+        static constexpr State StateConvert(std::string const& state)
         {
             return (state == "RELEASED") ? RELEASED : ARCHIVED;
         }
 
-        static inline std::string StateConvert(State const state)
+        static constexpr std::string StateConvert(State const state)
         {
             return (state == RELEASED) ? "RELEASED" : "ARCHIVED";
         }