[WIP] Switch to Noto Sans Korean #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ZeLonewolf Anything I can do to help with this PR? The line height issue is constantly nagging at me… |
|
I believe this is good to go, except I don't have any good way to test it. |
|
Well, if it seems good then in true OSM fashion I'd just merge it and wait to see if anyone complains 😅 |
|
Seems reasonable to me. |
|
Looks like the build and deploy failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4
This PR switches the Hangul font to Noto Sans Korean. I also tried to switch over the Japanese scripts to Noto Sans as well, but it does not work for unexplained reasons. The fonteditor-core library reports a duplicate glyph codepoint whenever I try.
I also upgraded fonteditor-core for good measure.