Adding highway shields in Peru #1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claysmalley
reviewed
Dec 16, 2024
src/js/shield_defs.js
Outdated
| shields[`PE:departmental:${department}`], | ||
| shields[`PE:rural:${department}`], | ||
| ] = [ | ||
| escutcheonDownShield(12, Color.shields.white, Color.shields.black), |
There was a problem hiding this comment.
These shields are visually closer to the state highway shields of Mexico (see line 584). Let's factor that out into a reusable shield definition and use it here.
Side note: this is making it really clear how much we need a draw function for badge shields, and maybe support for crossbars and accent colors in some of the functions...
There was a problem hiding this comment.
Thanks, this should be addressed with the latest commit.
|
Ok, turning back to this after the holidays. I've moved the definition for the crossbar'd escutcheon shield so that it can be reused, and renamed those 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Peruvian national, departmental, and rural route shields to the map after some tagging changes. Only the national routes required a new shield.
Localhost link
Pan-American, national, departmental, and rural highway shields in Peru
