Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete unused Japanese urban expressway shield #309

Merged
merged 1 commit into from
May 8, 2022

Conversation

1ec5
Copy link
Member

@1ec5 1ec5 commented May 7, 2022

This shield is unused. It was originally added in deaaf87 for #219, but its usage was removed in 3def876 for #307. Since we don’t have a good way of tracking unused images yet, let’s leave this image out of the repository until #219 lands. We can also continue to refine the image there if necessary.

@1ec5 1ec5 requested a review from ZeLonewolf May 7, 2022 19:27
@1ec5 1ec5 self-assigned this May 7, 2022
Copy link
Member

@claysmalley claysmalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me.

Copy link
Member

@ZeLonewolf ZeLonewolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YAGNI

@ZeLonewolf ZeLonewolf merged commit 6442374 into main May 8, 2022
@ZeLonewolf ZeLonewolf deleted the 1ec5-jp-urban-unused-307 branch May 8, 2022 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants