Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crossover is a rail service #531

Closed
wants to merge 1 commit into from
Closed

Crossover is a rail service #531

wants to merge 1 commit into from

Conversation

jleedev
Copy link
Member

@jleedev jleedev commented Aug 2, 2022

Fixes:

Screenshot_20220802-192413

@jleedev jleedev requested a review from claysmalley August 2, 2022 23:25
@claysmalley
Copy link
Member

This rendering is intentional. service=crossover is not rendered as service track on other renderers, nor should it be.

The styling introduced in #476 does apply special styling to service=crossover, but only to disable the dash pattern, not to make the line thinner.

@claysmalley claysmalley closed this Aug 2, 2022
@jleedev jleedev deleted the jleedev-rail branch August 2, 2022 23:43
@claysmalley
Copy link
Member

To clarify, service=crossover should only connect a main track to a main track. If one of the connecting tracks is a service track, that is a tagging error—even though it is functionally a crossover, the value of service=* should match the adjacent tracks.

@jleedev
Copy link
Member Author

jleedev commented Aug 2, 2022

Well, it looks a little strange for heavy rail to not all be the same line width. What's the motivation for emphasizing crossover in this way?

Perhaps adding line-cap: round would smooth it a little bit.

@jleedev
Copy link
Member Author

jleedev commented Aug 2, 2022

Got it, so it should always — in principle — be between two parallel non-service rails that extend in both directions.

@claysmalley
Copy link
Member

I introduced a lot of these tagging errors myself a couple years ago. I went through and undid hundreds of them last week, but I didn't change anything that had been edited by someone else in the meantime. So if you come across any of these and you find me in the edit history, you know why 😬

@jleedev
Copy link
Member Author

jleedev commented Aug 3, 2022

I do see that osm-carto also renders crossover with this use case apparently in mind:

Screen Shot 2022-08-03 at 08 39 39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants