Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iraq highway shields #557

Merged
merged 3 commits into from
Nov 26, 2022
Merged

Iraq highway shields #557

merged 3 commits into from
Nov 26, 2022

Conversation

1ec5
Copy link
Member

@1ec5 1ec5 commented Oct 9, 2022

Added a shield definition for Iraq (national) highways. Only highways have been mapped as relations so far; numbered freeways and roads don’t have relations yet. As in Iran (#463), route shields in Iraq bear both writing systems on separate panels, but this style is only showing the Western Arabic numerals that have been tagged in ref.

highways

src/js/shield_defs.js Outdated Show resolved Hide resolved
@ZeLonewolf
Copy link
Member

Are the wide rectangles a deliberate design decision based on OTG signage?

image

Also, I notice the "5" route in the northeast of the clip above, is that an artifact awaiting a tile update?

@1ec5
Copy link
Member Author

1ec5 commented Nov 26, 2022

Are the wide rectangles a deliberate design decision based on OTG signage?

This was @claysmalley’s suggestion in #557 (comment). You can just barely make out the green highway shields on the left side of this photo:

Falluja

Also, I notice the "5" route in the northeast of the clip above, is that an artifact awaiting a tile update?

That’s Road 5. So far, two roads have been tagged network=IQ-road. Should we add support for this tag even though it uses a hyphen instead of a colon? As far as I know, roads have the same green shield as highways.

@claysmalley
Copy link
Member

claysmalley commented Nov 26, 2022

In general, I'm not in favor of supporting network values like XX-roads where XX is a country code. I think these network values sprung from a misunderstanding of European road networks (e-road, FR:A-road, etc.) and there's a better country-and-colon-prefixed value to use in every case.

@1ec5
Copy link
Member Author

1ec5 commented Nov 26, 2022

We can take care of roads and motorways in separate PRs once the tagging for those catches up to the tagging for highways.

Copy link
Member

@claysmalley claysmalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@1ec5 1ec5 merged commit ae63bd3 into main Nov 26, 2022
@1ec5 1ec5 deleted the 1ec5-iq branch November 26, 2022 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants