Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conversion from fill-opacity to CSS #671

Merged
merged 2 commits into from
Jan 7, 2023

Conversation

1ec5
Copy link
Member

@1ec5 1ec5 commented Jan 7, 2023

Unmultiply RGB components by the alpha component. If fill-opacity is unspecified, use fill-color directly in CSS. Apply fill-extrusion-opacity to the whole feature, not just its fill.

Tucson

Fixes #664.

Unmultiply RGB components by the alpha component. If fill-opacity is unspecified, use fill-color directly in CSS.
@1ec5 1ec5 added the bug Something isn't working label Jan 7, 2023
@1ec5 1ec5 self-assigned this Jan 7, 2023
Unlike fill-opacity, fill-extrusion-opacity affects the whole feature, not just its fill.
@ZeLonewolf
Copy link
Member

I zoomed to the following location (localhost link)

I don't seem to be seeing intermittent water show up here.

image

@1ec5
Copy link
Member Author

1ec5 commented Jan 7, 2023

I don't seem to be seeing intermittent water show up here.

These are river areas, not lake areas. #632 didn’t add a legend entry for river areas because they would be redundant to river lines. If this is confusing, perhaps there needs to be an ability for a single legend entry to be depicted as both a swatch and a line, each occupying half the table cell. It’s possible that river areas were showing up by mistake until #637 tweaked the filters on these layers.

@ZeLonewolf
Copy link
Member

Looks good on a lake, then. Intermittent river areas are probably worth a legend entry, separate from the river area + river line for a normal river.
image

@1ec5
Copy link
Member Author

1ec5 commented Jan 7, 2023

Intermittent river areas are probably worth a legend entry, separate from the river area + river line for a normal river.

Yeah, this needs more thought. The legend doesn’t depict river areas at all, regardless of intermittency. It isn’t difficult to add a separate entry for river areas, but the difficulty is what to call it and how to visually distinguish it from the entry for lakes and ponds.

@1ec5 1ec5 merged commit 5c80a57 into main Jan 7, 2023
@1ec5 1ec5 deleted the 1ec5-legend-intermittent-water-fill-alpha-664 branch January 7, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Legend displays intermittent lake or pond with gray fill instead of light blue
2 participants