Don't render one-way arrows on highway features that aren't rendered #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR Preview: Sprite Sheets:
|
1ec5
approved these changes
Sep 18, 2023
Comment on lines
12
to
+13
| ["!", ["in", ["get", "brunnel"], ["literal", ["bridge", "tunnel"]]]], | ||
| ["!", ["in", ["get", "class"], ["literal", ["path", "track"]]]], |
There was a problem hiding this comment.
Nit: I find this somewhat more readable, though I don’t think it would affect performance:
Suggested change
| ["!", ["in", ["get", "brunnel"], ["literal", ["bridge", "tunnel"]]]], | |
| ["!", ["in", ["get", "class"], ["literal", ["path", "track"]]]], | |
| ["match", ["get", "brunnel"], ["bridge", "tunnel"], false, true], | |
| ["match", ["get", "class"], ["path", "track"], false, true], |
|
I felt that using the same type of expression as directly above (for brunnel) was more readable. |
|
I think this version is fine, especially since we'll be presumably throwing it away once tracks and paths actually get implemented anyways. Based on @adamfranco's comments on #717, we're not concerned about a conflict with ongoing work. Therefore, I agree that this is good to merge. Thanks for the PR! |
|
Yep! I'm also hoping this is temporary, seeing as I ❤️ trails |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the style is rendering oneway arrows on paths. This PR removes those (and on tracks, as they aren't rendered either)
on
main:on this branch:
