highway-almost-junction: avoid warnings on the intersecting node in P-shaped ways #2436
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently analyser osmosis-highway-almost-junction also gives warnings about ways close to the intersecting node of P-shaped ways. This is usually incorrect.

Examples:
This PR disables the warning for the intersecting node.
Note: I didn't use
ST_IsSimple
, since this also caused a lot of false negatives for the other end node. ExampleAlso adds test cases