perf(types): 3x speedup MakePartSet (#3117) #83
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some benchmarks, and significantly speeds up types.MakePartSet, and Partset.AddPart. (Used by the block proposer, and every consensus instance) It does so by doing two things:
I do the same hash optimization for proof.Verify, which is used in the add block part codepath for both the proposer and every full node.
New:
Old:
System wide, this is definitely not our issue (looks like roughly .1ms per blockpart), but still definitely useful time to remove
.changelog
(we use unclog to manage our changelog)docs/
orspec/
) and code commentsPR checklist
.changelog
(we use unclog to manage our changelog)docs/
orspec/
) and code comments