Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish Stage #3959

Merged
merged 5 commits into from
Nov 19, 2024
Merged

Publish Stage #3959

merged 5 commits into from
Nov 19, 2024

Conversation

JoseRFelix
Copy link
Collaborator

@JoseRFelix JoseRFelix commented Nov 18, 2024 •
edited
Loading

Changes

  • Fix CPU instability in useSwap
  • Use denom to avoid excluding variants in deposits
  • Create lock file to manage asset list image cache
  • Convert variants: check for large difference in amount
  • Fix Supercharged Pool creation is missing several assets

greg-nagy and others added 3 commits November 18, 2024 08:29
@greg-nagy
👻 Who Ya Gonna Call?: Fix referential instability in useSwap to sto…
de3c0d8 
…p continuous rerenders and high CPU usage (#3956)

* hook and their props changes debug logs

swap changes

* fix: stabilize switchAssets

* fix: stabilize outputDifference

* feat: add useDeepMemo to use deep equal when memoizing

lodash.isEqual was another option for deep equality checks but
fast-deep-equal is lot smaller and more performant

* fix: stabilize quote

* fix: stabalize useSwapAmountInput

this one was the trigger for multiple changes
inAmountInput, outAmountInput, spotPriceQuote, sendTradeTokeninTx

* fix: stabilize totalFee

* Revert "hook and their props changes debug logs"

This reverts commit 4b42274.

* fix: coderabbit
@JoseRFelix
(Deposit/Withdraw) Use denom to avoid excluding variants in deposits (#…
e3f110a 
…3952)
@JoseRFelix
(DevX) Create lock file to manage asset list image cache (#3957)
3c202ad 
* feat: create lock file to manage asset list image cache

* improvement: comment

* fix: build
@vercel Vercel
Copy link

vercel bot commented Nov 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
osmosis-frontend ✅ Ready (Inspect) Visit Preview ✅ 3 resolved Nov 19, 2024 5:45pm
osmosis-frontend-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 5:45pm
osmosis-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 5:45pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
osmosis-frontend-datadog ⬜️ Ignored (Inspect) Visit Preview Nov 19, 2024 5:45pm
osmosis-frontend-edgenet ⬜️ Ignored (Inspect) Nov 19, 2024 5:45pm

@JoseRFelix JoseRFelix requested review from a team November 18, 2024 18:14
@JoseRFelix
(Pool creation) Supercharged Pool creation is missing several assets (#…
f305d29 
…3960)

* feat: display unverified and preview assets in supercharged pool creation

* improvement: @jonator feedback
@JoseRFelix JoseRFelix merged commit f8f2d4b into master Nov 19, 2024
154 of 155 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavideSegullo DavideSegullo DavideSegullo approved these changes

@MaxMillington MaxMillington MaxMillington approved these changes

@jonator jonator jonator approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JoseRFelix @jonator @MaxMillington @DavideSegullo @greg-nagy