Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish Stage #3999

Merged
merged 5 commits into from
Dec 9, 2024
Merged

Publish Stage #3999

merged 5 commits into from
Dec 9, 2024

Conversation

jonator
Copy link
Member

@jonator jonator commented Dec 6, 2024 •
edited
Loading

What is the purpose of the change:

  • env var consolidation for base URL of numia/historical data service
  • Cleanup blockworks code
  • Further refine SQS pools params (used in asset page pool section)

deividaspetraitis and others added 2 commits December 6, 2024 14:19
@deividaspetraitis
BE-664 | Fix: filter pools by denom in assets page (#3998)
c8c20a2 
Fixes filtering pools by denom name using dedicated filter inside assets page instead of leveraging search feature for more precise results
@jonator
Cleanup env (#3996)
6c9e61a 
* clean up env

* update durbo deps

* update workflows

* update KV vars

* consolidate NUMIA_BASE_URL

* lint fix
@vercel Vercel
Copy link

vercel bot commented Dec 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
osmosis-frontend ✅ Ready (Inspect) Visit Preview ✅ 3 resolved Dec 9, 2024 5:11pm
osmosis-frontend-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 5:11pm
osmosis-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 5:11pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
osmosis-frontend-datadog ⬜️ Ignored (Inspect) Visit Preview Dec 9, 2024 5:11pm
osmosis-frontend-edgenet ⬜️ Ignored (Inspect) Dec 9, 2024 5:11pm

@jonator jonator marked this pull request as draft December 6, 2024 15:09
@jonator
Copy link
Member Author

jonator commented Dec 6, 2024

Waiting until Monday

@jonator
Copy link
Member Author

jonator commented Dec 6, 2024

@JoseRFelix was playing around with the new gas logic and I'm still seeing 500s in dev preview logs

https://vercel.com/osmo-labs/osmosis-frontend/9E38TUPKwXiKVSbnLSem3bMoaaKC/logs?levels=error&page=2&selectedLogId=5jg6l-1733503602323-844b62b8e504

@jonator jonator marked this pull request as ready for review December 9, 2024 16:05
@jonator jonator merged commit 7fb1c6f into master Dec 9, 2024
126 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamal-sutra kamal-sutra kamal-sutra approved these changes

@CryptoAssassin1 CryptoAssassin1 CryptoAssassin1 approved these changes

@DavideSegullo DavideSegullo DavideSegullo approved these changes

@deividaspetraitis deividaspetraitis deividaspetraitis approved these changes

@MaxMillington MaxMillington Awaiting requested review from MaxMillington

@JoseRFelix JoseRFelix Awaiting requested review from JoseRFelix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jonator @deividaspetraitis @DavideSegullo @CryptoAssassin1 @kamal-sutra @JoseRFelix @yury-dubinin