Temporary hide Moonpay #4038
Temporary hide Moonpay #4038
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Skipped Deployments
|
|
Caution Review failedThe pull request is closed. WalkthroughThe changes remove the Moonpay integration from the FiatRampsModal component. The import for Moonpay has been deleted, and the switch case handling the "moonpay" key now returns null instead of rendering the Moonpay component. This disables Moonpay functionality while preserving the control flow for other fiat ramp keys. Additionally, the Options function in the fiat-on-ramp selection has been updated to exclude the Moonpay entry, leaving only other available options. Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant M as FiatRampsModal
participant S as Switch Statement
U->>M: Open modal with fiatRampKey
M->>S: Evaluate fiatRampKey
alt fiatRampKey == "moonpay"
S->>M: Return null (Moonpay integration disabled)
else
S->>M: Render corresponding fiat ramp component
end
Possibly related PRs
Suggested reviewers
Tip 🌐 Web search-backed reviews and chat
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
packages/web/modals/fiat-ramps.tsx (2)
12-18: Consider removing moonpay from FIAT_RAMPS_PRETTY_NAMES while it's disabled.Since Moonpay integration is temporarily hidden, keeping it in the pretty names could lead to confusion as the UI might still show "MoonPay" as an option even though it won't render anything.
const FIAT_RAMPS_PRETTY_NAMES: Record<FiatRampKey, string> = { kado: "Kado", layerswapcoinbase: "Coinbase Layer Swap", - moonpay: "MoonPay", onrampmoney: "Onramp.money", transak: "Transak", };
72-73: Add a comment explaining why Moonpay is temporarily disabled.To improve code maintainability and prevent accidental removal of this case, consider adding a comment explaining why Moonpay is temporarily hidden and any conditions for re-enabling it.
case "moonpay": + // Temporarily disabled Moonpay integration - see PR #4038 return null;
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/web/modals/fiat-ramps.tsx(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (17)
- GitHub Check: Summary
- GitHub Check: test (20.x, proto-codecs)
- GitHub Check: test (20.x, bridge)
- GitHub Check: test (20.x, tx)
- GitHub Check: test (20.x, math)
- GitHub Check: test (20.x, pools)
- GitHub Check: test (20.x, bridge)
- GitHub Check: test (20.x, stores)
- GitHub Check: test (20.x, math)
- GitHub Check: test (20.x, server)
- GitHub Check: test (20.x, pools)
- GitHub Check: test (20.x, stores)
- GitHub Check: test (20.x, utils)
- GitHub Check: test (20.x, server)
- GitHub Check: test (20.x, web)
- GitHub Check: wait-for-deployment
- GitHub Check: lint-workspace
No description provided.