Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add cosmos.msg.v1.service to message services #8820

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+743 −708
Open

fix: add cosmos.msg.v1.service to message services #8820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3395d02
Add msg service
mattverse Nov 13, 2024
fa01dd4
Add changelog
mattverse Nov 13, 2024
8b4fcd9
Merge branch 'main' into mattverse/msg
mattverse Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
* [#8563](https://github.com/osmosis-labs/osmosis/pull/8755) [x/concentratedliquidity]: Fix Incorrect Event Emission
* [#8765](https://github.com/osmosis-labs/osmosis/pull/8765) fix concurrency issue in go test(x/lockup)
* [#8791](https://github.com/osmosis-labs/osmosis/pull/8791) fix: superfluid log for error that should be ignored
* [#8820](https://github.com/osmosis-labs/osmosis/pull/8820) fix: add cosmos.msg.v1.service to message services

### State Machine Breaking

Expand Down
2 changes: 2 additions & 0 deletions proto/osmosis/concentratedliquidity/poolmodel/concentrated/v1beta1/tx.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ import "cosmos/msg/v1/msg.proto";
option go_package = "github.com/osmosis-labs/osmosis/v27/x/concentrated-liquidity/model";

service Msg {
option (cosmos.msg.v1.service) = true;

Comment on lines +11 to +12
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Missing cosmos.msg.v1.service option in multiple proto files.

The following proto files are missing the required cosmos.msg.v1.service option:

  • proto/osmosis/tokenfactory/v1beta1/tx.proto
  • proto/osmosis/valsetpref/v1beta1/tx.proto
  • proto/osmosis/txfees/v1beta1/tx.proto
  • proto/osmosis/gamm/v1beta1/tx.proto
  • proto/osmosis/gamm/poolmodels/stableswap/v1beta1/tx.proto
  • proto/osmosis/gamm/poolmodels/balancer/v1beta1/tx.proto
  • proto/osmosis/concentratedliquidity/poolmodel/concentrated/v1beta1/tx.proto
  • proto/osmosis/cosmwasmpool/v1beta1/tx.proto
  • proto/osmosis/cosmwasmpool/v1beta1/model/tx.proto
  • proto/osmosis/superfluid/tx.proto
  • proto/osmosis/smartaccount/v1beta1/tx.proto
  • proto/osmosis/lockup/tx.proto
  • proto/osmosis/incentives/tx.proto
  • proto/osmosis/protorev/v1beta1/tx.proto
  • proto/osmosis/poolmanager/v1beta1/tx.proto
  • proto/osmosis/ibchooks/tx.proto

Please ensure that all Msg services across these proto files include the option (cosmos.msg.v1.service) = true; declaration to maintain consistency and adhere to Cosmos SDK protobuf standards.

🔗 Analysis chain

LGTM! Verify consistency across other proto files.

The addition of cosmos.msg.v1.service option is correct and follows Cosmos SDK protobuf standards. This is a non-breaking change that enhances service discovery and code generation.

Let's verify that this change is consistently applied across other similar proto files:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for consistency of cosmos.msg.v1.service option across proto files
# Expected: All Msg services should have this option

# Search for Msg services in proto files
rg -l "service Msg" --type proto

# Check which of these services have the cosmos.msg.v1.service option
rg -l "option \(cosmos\.msg\.v1\.service\) = true" --type proto

# Find any Msg services that might be missing the option
rg -l "service Msg" --type proto | while read file; do
  if ! grep -q "option (cosmos.msg.v1.service) = true" "$file"; then
    echo "Missing cosmos.msg.v1.service option in: $file"
  fi
done

Length of output: 237

Script:

#!/bin/bash
# Description: Check for consistency of cosmos.msg.v1.service option across proto files
# Expected: All Msg services should have this option

# Search for Msg services in proto files
rg -l "service Msg" --glob "*.proto"

# Check which of these services have the cosmos.msg.v1.service option
rg -l "option (cosmos\.msg\.v1\.service) = true;" --glob "*.proto"

# Find any Msg services that might be missing the option
for file in $(rg -l "service Msg" --glob "*.proto"); do
  if ! rg -q "option (cosmos\.msg\.v1\.service) = true;" "$file"; then
    echo "Missing cosmos.msg.v1.service option in: $file"
  fi
done

Length of output: 6512

rpc CreateConcentratedPool(MsgCreateConcentratedPool)
returns (MsgCreateConcentratedPoolResponse);
}
Expand Down
2 changes: 2 additions & 0 deletions proto/osmosis/gamm/poolmodels/balancer/v1beta1/tx.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ import "cosmos/msg/v1/msg.proto";
option go_package = "github.com/osmosis-labs/osmosis/v27/x/gamm/pool-models/balancer";

service Msg {
option (cosmos.msg.v1.service) = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Inconsistency detected: Missing cosmos.msg.v1.service option in multiple Msg services.

The following proto files define service Msg without the required cosmos.msg.v1.service option:

  • proto/osmosis/superfluid/tx.proto
  • proto/osmosis/txfees/v1beta1/tx.proto
  • proto/osmosis/valsetpref/v1beta1/tx.proto
  • proto/osmosis/gamm/v1beta1/tx.proto
  • proto/osmosis/smartaccount/v1beta1/tx.proto
  • proto/osmosis/tokenfactory/v1beta1/tx.proto
  • proto/osmosis/concentratedliquidity/v1beta1/tx.proto
  • proto/osmosis/lockup/tx.proto
  • proto/osmosis/concentratedliquidity/poolmodel/concentrated/v1beta1/tx.proto
  • proto/osmosis/protorev/v1beta1/tx.proto
  • proto/osmosis/gamm/poolmodels/balancer/v1beta1/tx.proto
  • proto/osmosis/gamm/poolmodels/stableswap/v1beta1/tx.proto
  • proto/osmosis/poolmanager/v1beta1/tx.proto
  • proto/osmosis/incentives/tx.proto
  • proto/osmosis/ibchooks/tx.proto
  • proto/osmosis/cosmwasmpool/v1beta1/tx.proto

Please ensure that the cosmos.msg.v1.service option is added to all Msg service definitions to maintain consistency across the codebase.

🔗 Analysis chain

LGTM! The Cosmos message service option is correctly implemented.

The addition of option (cosmos.msg.v1.service) = true; follows the Cosmos SDK conventions for message services and is properly placed within the service definition block.

Let's verify the consistency of this change across other proto files:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check if the cosmos.msg.v1.service option is consistently applied across all proto files with Msg services
# Expected: All Msg services should have this option

# Search for Msg service definitions and verify they include the cosmos.msg.v1.service option
rg -U "service Msg \{[\s\S]*?\}" --type proto | grep -v "cosmos\.msg\.v1\.service"

# If the above command returns results, it indicates Msg services that are missing the option

Length of output: 114

Script:

#!/bin/bash
# Description: Check if the cosmos.msg.v1.service option is consistently applied across all proto files with Msg services
# Expected: All Msg services should have this option

# Search for Msg service definitions and verify they include the cosmos.msg.v1.service option
rg -U "service Msg \{[\s\S]*?\}" --glob "*.proto" | grep -v "cosmos\.msg\.v1\.service"

# If the above command returns results, it indicates Msg services that are missing the option

Length of output: 18427


rpc CreateBalancerPool(MsgCreateBalancerPool)
returns (MsgCreateBalancerPoolResponse);
}
Expand Down
2 changes: 2 additions & 0 deletions proto/osmosis/gamm/poolmodels/stableswap/v1beta1/tx.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ import "cosmos/msg/v1/msg.proto";
option go_package = "github.com/osmosis-labs/osmosis/v27/x/gamm/pool-models/stableswap";

service Msg {
option (cosmos.msg.v1.service) = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Inconsistency Found: Missing cosmos.msg.v1.service option in proto/osmosis/cosmwasmpool/v1beta1/tx.proto.

  • Add option (cosmos.msg.v1.service) = true; to the Msg service.
🔗 Analysis chain

LGTM! Correctly adds Cosmos message service option.

The addition of option (cosmos.msg.v1.service) = true; is correct and aligns with Cosmos SDK standards for message services.

Let's verify this change is consistently applied across other proto files:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for consistency of cosmos.msg.v1.service option across proto files
# Expected: All Msg services should have this option

# Search for Msg services in proto files
rg -U "service Msg \{[\s\S]*?\}" --type proto

# Search for the cosmos.msg.v1.service option
rg "option \(cosmos\.msg\.v1\.service\) = true;" --type proto

Length of output: 171

Script:

#!/bin/bash
# Description: Check for consistency of cosmos.msg.v1.service option across proto files
# Expected: All Msg services should have this option

# Search for Msg services in proto files
rg -U "service Msg \{[\s\S]*?\}" -g "*.proto"

# Search for the cosmos.msg.v1.service option
rg "option \(cosmos\.msg\.v1\.service\) = true;" -g "*.proto"

Length of output: 20812


rpc CreateStableswapPool(MsgCreateStableswapPool)
returns (MsgCreateStableswapPoolResponse);
rpc StableSwapAdjustScalingFactors(MsgStableSwapAdjustScalingFactors)
Expand Down
2 changes: 2 additions & 0 deletions proto/osmosis/gamm/v1beta1/tx.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ import "cosmos/msg/v1/msg.proto";
option go_package = "github.com/osmosis-labs/osmosis/v27/x/gamm/types";

service Msg {
option (cosmos.msg.v1.service) = true;

Comment on lines +13 to +14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Inconsistent application of cosmos.msg.v1.service option detected.

The following proto files have service Msg without the cosmos.msg.v1.service option:

  • ./proto/osmosis/concentratedliquidity/v1beta1/tx.proto
  • ./proto/osmosis/cosmwasmpool/v1beta1/tx.proto

Additionally, ./proto/osmosis/cosmwasmpool/v1beta1/model/tx.proto uses service MsgCreator instead of service Msg.

Please ensure the cosmos.msg.v1.service option is added for consistency across all Msg services.

🔗 Analysis chain

LGTM! Consistent with Cosmos SDK message service pattern.

The addition of cosmos.msg.v1.service option is correct and follows the standard Cosmos SDK pattern for declaring message services.

Let's verify similar changes across other proto files:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify consistent application of cosmos.msg.v1.service option across proto files

# Find all proto files with Msg services and check for the cosmos.msg.v1.service option
fd -e proto -x grep -l "service Msg" {} | while read -r file; do
  echo "=== $file ==="
  grep -A 1 "service Msg" "$file"
done

Length of output: 4489

rpc JoinPool(MsgJoinPool) returns (MsgJoinPoolResponse);
rpc ExitPool(MsgExitPool) returns (MsgExitPoolResponse);
rpc SwapExactAmountIn(MsgSwapExactAmountIn)
Expand Down
2 changes: 2 additions & 0 deletions proto/osmosis/ibchooks/tx.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ option go_package = "github.com/osmosis-labs/osmosis/v27/x/ibc-hooks/types";

// Msg defines the Msg service.
service Msg {
option (cosmos.msg.v1.service) = true;

// EmitIBCAck checks the sender can emit the ack and writes the IBC
// acknowledgement
rpc EmitIBCAck(MsgEmitIBCAck) returns (MsgEmitIBCAckResponse);
Expand Down
2 changes: 2 additions & 0 deletions proto/osmosis/incentives/tx.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ import "cosmos/msg/v1/msg.proto";
option go_package = "github.com/osmosis-labs/osmosis/v27/x/incentives/types";

service Msg {
option (cosmos.msg.v1.service) = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Missing cosmos.msg.v1.service option in proto/osmosis/cosmwasmpool/v1beta1/tx.proto.

The Msg service in proto/osmosis/cosmwasmpool/v1beta1/tx.proto does not include option (cosmos.msg.v1.service) = true;, which is inconsistent with other proto files and may affect integration with the Cosmos SDK framework.

🔗 Analysis chain

LGTM! Correctly implements Cosmos SDK message service standard.

The addition of option (cosmos.msg.v1.service) = true; properly declares this as a Cosmos SDK message service, which is the correct implementation pattern for Cosmos-based blockchain modules. This change maintains compatibility while enhancing integration with the Cosmos ecosystem.

Let's verify this change is consistent across other proto files mentioned in the summary:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify consistent implementation of cosmos.msg.v1.service option across proto files
# Expected: All Msg services should have the cosmos.msg.v1.service option

# Search for Msg service definitions and their associated cosmos.msg.v1.service option
rg -U "service Msg \{[\s\S]*?\}" proto/osmosis/

Length of output: 19569


rpc CreateGauge(MsgCreateGauge) returns (MsgCreateGaugeResponse);
rpc AddToGauge(MsgAddToGauge) returns (MsgAddToGaugeResponse);
rpc CreateGroup(MsgCreateGroup) returns (MsgCreateGroupResponse);
Expand Down
2 changes: 2 additions & 0 deletions proto/osmosis/lockup/tx.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ option go_package = "github.com/osmosis-labs/osmosis/v27/x/lockup/types";

// Msg defines the Msg service.
service Msg {
option (cosmos.msg.v1.service) = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Missing cosmos.msg.v1.service option in multiple proto files:

  • proto/osmosis/concentratedliquidity/v1beta1/tx.proto
  • proto/osmosis/cosmwasmpool/v1beta1/tx.proto
  • proto/osmosis/cosmwasmpool/v1beta1/model/tx.proto
🔗 Analysis chain

Verify consistent implementation across message services.

Let's ensure this standardization is applied consistently across all message services in the codebase.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for consistency of cosmos.msg.v1.service option across proto files

# Find all proto files containing "service Msg"
echo "Checking Msg services in proto files..."
rg -l "service Msg" --type proto | while read -r file; do
    echo "=== $file ==="
    # Check if the file has the cosmos.msg.v1.service option
    if ! rg "option \(cosmos\.msg\.v1\.service\) = true;" "$file" --quiet; then
        echo "WARNING: Missing cosmos.msg.v1.service option"
    fi
    # Show the Msg service definition context
    rg "service Msg \{" -A 5 "$file"
done

# Verify the import statement exists where the option is used
echo -e "\nChecking for proper imports..."
rg "option \(cosmos\.msg\.v1\.service\) = true;" -l --type proto | while read -r file; do
    echo "=== $file ==="
    if ! rg "import \"cosmos/msg/v1/msg\.proto\";" "$file" --quiet; then
        echo "WARNING: Missing required import: cosmos/msg/v1/msg.proto"
    fi
done

Length of output: 357

Script:

#!/bin/bash
# Description: Check for consistency of cosmos.msg.v1.service option across proto files

# Find all proto files containing "service Msg"
echo "Checking Msg services in proto files..."
rg -l "service Msg" -g "*.proto" | while read -r file; do
    echo "=== $file ==="
    # Check if the file has the cosmos.msg.v1.service option
    if ! rg "option \(cosmos\.msg\.v1\.service\) = true;" "$file" --quiet; then
        echo "WARNING: Missing cosmos.msg.v1.service option"
    fi
    # Show the Msg service definition context
    rg "service Msg \{" -A 5 "$file"
done

# Verify the import statement exists where the option is used
echo -e "\nChecking for proper imports..."
rg "option \(cosmos\.msg\.v1\.service\) = true;" -l -g "*.proto" | while read -r file; do
    echo "=== $file ==="
    if ! rg "import \"cosmos/msg/v1/msg\.proto\";" "$file" --quiet; then
        echo "WARNING: Missing required import: cosmos/msg/v1/msg.proto"
    fi
done

Length of output: 12031


// LockTokens lock tokens
rpc LockTokens(MsgLockTokens) returns (MsgLockTokensResponse);
// BeginUnlockingAll begin unlocking all tokens
Expand Down
2 changes: 2 additions & 0 deletions proto/osmosis/poolmanager/v1beta1/tx.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ import "cosmos/msg/v1/msg.proto";
option go_package = "github.com/osmosis-labs/osmosis/v27/x/poolmanager/types";

service Msg {
option (cosmos.msg.v1.service) = true;

Comment on lines +13 to +14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Inconsistent application of cosmos.msg.v1.service option across proto files.

The following files are missing the option (cosmos.msg.v1.service) = true; in their Msg service definitions:

  • proto/osmosis/concentratedliquidity/v1beta1/tx.proto
  • proto/osmosis/cosmwasmpool/v1beta1/tx.proto
  • proto/osmosis/smartaccount/v1beta1/tx.proto
  • proto/osmosis/superfluid/tx.proto
  • proto/osmosis/tokenfactory/v1beta1/tx.proto
  • proto/osmosis/lockup/tx.proto
  • proto/osmosis/protorev/v1beta1/tx.proto
  • proto/osmosis/txfees/v1beta1/tx.proto
  • proto/osmosis/valsetpref/v1beta1/tx.proto
🔗 Analysis chain

LGTM! Verify consistency across other proto files.

The addition of option (cosmos.msg.v1.service) = true; is correct and properly integrated with the required import. This change enhances the service's compatibility with the Cosmos SDK messaging framework.

Let's verify this change is consistently applied across other proto files:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for consistency of cosmos.msg.v1.service option across proto files
# Expected: All Msg services should have this option

# Find all proto files and check for Msg services without the cosmos.msg.v1.service option
fd -e proto | while read -r file; do
  if grep -l "service Msg {" "$file" > /dev/null; then
    if ! grep -A 1 "service Msg {" "$file" | grep -q "option (cosmos\.msg\.v1\.service)"; then
      echo "Warning: $file contains Msg service but missing cosmos.msg.v1.service option"
    fi
  fi
done

Length of output: 12007

rpc SwapExactAmountIn(MsgSwapExactAmountIn)
returns (MsgSwapExactAmountInResponse);
rpc SwapExactAmountOut(MsgSwapExactAmountOut)
Expand Down
2 changes: 2 additions & 0 deletions proto/osmosis/protorev/v1beta1/tx.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ import "cosmos/msg/v1/msg.proto";
option go_package = "github.com/osmosis-labs/osmosis/v27/x/protorev/types";

service Msg {
option (cosmos.msg.v1.service) = true;

// SetHotRoutes sets the hot routes that will be explored when creating
// cyclic arbitrage routes. Can only be called by the admin account.
rpc SetHotRoutes(MsgSetHotRoutes) returns (MsgSetHotRoutesResponse) {
Expand Down
2 changes: 2 additions & 0 deletions proto/osmosis/smartaccount/v1beta1/tx.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ option go_package = "github.com/osmosis-labs/osmosis/v27/x/smart-account/types";

// Msg defines the Msg service.
service Msg {
option (cosmos.msg.v1.service) = true;

rpc AddAuthenticator(MsgAddAuthenticator)
returns (MsgAddAuthenticatorResponse);
rpc RemoveAuthenticator(MsgRemoveAuthenticator)
Expand Down
2 changes: 2 additions & 0 deletions proto/osmosis/superfluid/tx.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ option go_package = "github.com/osmosis-labs/osmosis/v27/x/superfluid/types";

// Msg defines the Msg service.
service Msg {
option (cosmos.msg.v1.service) = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Add option (cosmos.msg.v1.service) = true; to proto/osmosis/superfluid/tx.proto

The option (cosmos.msg.v1.service) = true; is missing in proto/osmosis/superfluid/tx.proto, which is inconsistent with other proto files.

🔗 Analysis chain

Verify consistency with other proto files

Let's ensure this change is consistently applied across all message services in the codebase.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for all protobuf message services and check for the cosmos.msg.v1.service option
rg -U "service Msg \{[\s\S]*?\}" proto/ | grep -v "option (cosmos\.msg\.v1\.service)"

Length of output: 18426


// Execute superfluid delegation for a lockup
rpc SuperfluidDelegate(MsgSuperfluidDelegate)
returns (MsgSuperfluidDelegateResponse);
Expand Down
2 changes: 2 additions & 0 deletions proto/osmosis/tokenfactory/v1beta1/tx.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ option go_package = "github.com/osmosis-labs/osmosis/v27/x/tokenfactory/types";

// Msg defines the tokefactory module's gRPC message service.
service Msg {
option (cosmos.msg.v1.service) = true;

Comment on lines +14 to +15
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Missing cosmos.msg.v1.service option in proto files.

The following .proto files are missing the option (cosmos.msg.v1.service) = true;:

  • proto/osmosis/cosmwasmpool/v1beta1/tx.proto
  • proto/osmosis/cosmwasmpool/v1beta1/model/tx.proto
🔗 Analysis chain

LGTM! Correctly adds Cosmos message service option.

The addition of option (cosmos.msg.v1.service) = true; is properly implemented with the correct import and syntax. This change enhances the integration with the Cosmos messaging framework without affecting existing functionality.

Let's verify consistent implementation across other proto files:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify consistent implementation of cosmos.msg.v1.service option across proto files

# Check for proto files with Msg service but missing the cosmos.msg.v1.service option
echo "Checking for Msg services without cosmos.msg.v1.service option..."
rg -l "service Msg" --type proto | while read -r file; do
  if ! grep -q "option (cosmos\.msg\.v1\.service)" "$file"; then
    echo "Missing option in: $file"
  fi
done

# Verify correct import in all files using the option
echo -e "\nVerifying correct imports..."
rg -l "option \(cosmos\.msg\.v1\.service\)" --type proto | while read -r file; do
  if ! grep -q "import \"cosmos/msg/v1/msg\.proto\";" "$file"; then
    echo "Missing import in: $file"
  fi
done

Length of output: 397

Script:

#!/bin/bash
# Description: Verify consistent implementation of cosmos.msg.v1.service option across proto files

# Define proto file type
rg --type-add 'proto:*.proto' --type proto <<EOF
EOF

# Check for proto files with Msg service but missing the cosmos.msg.v1.service option
echo "Checking for Msg services without cosmos.msg.v1.service option..."
rg -l "service Msg" --type proto | while read -r file; do
  if ! grep -q "option (cosmos\.msg\.v1\.service)" "$file"; then
    echo "Missing option in: $file"
  fi
done

# Verify correct import in all files using the option
echo -e "\nVerifying correct imports..."
rg -l "option \(cosmos\.msg\.v1\.service\)" --type proto | while read -r file; do
  if ! grep -q "import \"cosmos/msg/v1/msg\.proto\";" "$file"; then
    echo "Missing import in: $file"
  fi
done

Length of output: 839

Script:

#!/bin/bash
# Description: Verify consistent implementation of cosmos.msg.v1.service option across proto files

# Define proto file type
rg --type-add 'proto:*.proto'

# Check for proto files with Msg service but missing the cosmos.msg.v1.service option
echo "Checking for Msg services without cosmos.msg.v1.service option..."
rg -l "service Msg" --type proto | while read -r file; do
  if ! grep -q "option (cosmos\.msg\.v1\.service)" "$file"; then
    echo "Missing option in: $file"
  fi
done

# Verify correct import in all files using the option
echo -e "\nVerifying correct imports..."
rg -l "option \(cosmos\.msg\.v1\.service\)" --type proto | while read -r file; do
  if ! grep -q "import \"cosmos/msg/v1/msg\.proto\";" "$file"; then
    echo "Missing import in: $file"
  fi
done

Length of output: 826

Script:

#!/bin/bash
# Description: Verify consistent implementation of cosmos.msg.v1.service option across proto files

# Check for proto files with Msg service but missing the cosmos.msg.v1.service option
echo "Checking for Msg services without cosmos.msg.v1.service option..."
rg -g '*.proto' -l "service Msg" | while read -r file; do
  if ! grep -q "option (cosmos\.msg\.v1\.service)" "$file"; then
    echo "Missing option in: $file"
  fi
done

# Verify correct import in all files using the option
echo -e "\nVerifying correct imports..."
rg -g '*.proto' -l "option \(cosmos\.msg\.v1\.service\)" | while read -r file; do
  if ! grep -q "import \"cosmos/msg/v1/msg\.proto\";" "$file"; then
    echo "Missing import in: $file"
  fi
done

Length of output: 4038

rpc CreateDenom(MsgCreateDenom) returns (MsgCreateDenomResponse);
rpc Mint(MsgMint) returns (MsgMintResponse);
rpc Burn(MsgBurn) returns (MsgBurnResponse);
Expand Down
2 changes: 2 additions & 0 deletions proto/osmosis/txfees/v1beta1/tx.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ import "cosmos/msg/v1/msg.proto";
option go_package = "github.com/osmosis-labs/osmosis/v27/x/txfees/types";

service Msg {
option (cosmos.msg.v1.service) = true;

Comment on lines +12 to +13
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Missing cosmos.msg.v1.service option in proto/osmosis/cosmwasmpool/v1beta1/tx.proto.

  • The Msg service in this file does not include the option (cosmos.msg.v1.service) = true;.
🔗 Analysis chain

LGTM! Correctly adds Cosmos message service option.

The addition of option (cosmos.msg.v1.service) = true; is correct and aligns with Cosmos SDK message service conventions.

Let's verify this change is consistently applied across related message services:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify consistent application of cosmos.msg.v1.service option across proto files
# Expected: All Msg services should have this option

# Search for Msg services in proto files
rg -U "service Msg \{[\s\S]*?\}" --type proto

# Search for the cosmos.msg.v1.service option in proto files
rg "option \(cosmos\.msg\.v1\.service\) = true;" --type proto

Length of output: 171

Script:

#!/bin/bash
# Description: Verify consistent application of cosmos.msg.v1.service option across proto files
# Expected: All Msg services should have this option

# Find all .proto files and search for 'service Msg { ... }'
fd --extension proto . | xargs rg -U "service Msg \{[\s\S]*?\}"

# Find all .proto files and search for the cosmos.msg.v1.service option
fd --extension proto . | xargs rg "option \(cosmos\.msg\.v1\.service\) = true;"

Length of output: 20848

rpc SetFeeTokens(MsgSetFeeTokens) returns (MsgSetFeeTokensResponse);
}

Expand Down
2 changes: 2 additions & 0 deletions proto/osmosis/valsetpref/v1beta1/tx.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ option go_package = "github.com/osmosis-labs/osmosis/v27/x/valset-pref/types";

// Msg defines the valset-pref module's gRPC message service.
service Msg {
option (cosmos.msg.v1.service) = true;

// SetValidatorSetPreference creates a set of validator preference.
// This message will process both create + update request.
rpc SetValidatorSetPreference(MsgSetValidatorSetPreference)
Expand Down
63 changes: 32 additions & 31 deletions x/concentrated-liquidity/model/tx.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

67 changes: 34 additions & 33 deletions x/gamm/pool-models/balancer/tx.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading