Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sort by select button #35

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Conversation

noumendarryl
Copy link
Contributor

Add sort by select button

This commit is linked to the issues #7 about sorting users by the ascending or descending amount of yotas the possess miniyotas.osscameroon.com

Changes

  • Added within the contributors.hbs file, the select button for sorting users by the ascending or descending amount of yotas
  • Updated the handleContributors asynchronous method in the index.ts file to add the conditional statements for performing sorting
  • Added a script block at the end of the contributors.hbs file to handle sorting requests while user changes options from the select button
  • Added a new helper eq in the handlebars.ts file to help with the maintaining the current value of the select button after the page reloads

How to test

  • Navigate to the contributors tab and select an option either Yotas (Low to High) or Yotas (High to Low) from the select button
  • Observe the result on the displayed list of users

Related Issues

@pythonbrad
Copy link
Member

pythonbrad commented Aug 22, 2024

Hello @noumendarryl , your pr looks good.

But there is changes not related to your pr topic like the correction of typos.

@noumendarryl
Copy link
Contributor Author

Hi @pythonbrad, I hope you're doing great. It's as if my pull request was accepted and I was wondering when it will be merged and successfully merged to the main branch of the miniyotas repository.

Can you please let me know when it will ?

@pythonbrad
Copy link
Member

pythonbrad commented Aug 27, 2024

Can you please let me know when it will ?

@noumendarryl, when another reviewer will review it.

We can assume that, at least two reviews are required before merging.

@noumendarryl
Copy link
Contributor Author

Hi @pythonbrad, Okay I get it now. I really hope it will be done very soon.

@noumendarryl
Copy link
Contributor Author

Also, I faced a lot of issues to contribute to issues related to osscameroon/osscameroon-website repository. These are particularly related to installing the backend dependencies.

Can you please take a look at it and let me know when we will be able to contribute ?

@pythonbrad
Copy link
Member

pythonbrad commented Aug 28, 2024

Can you please take a look at it and let me know when we will be able to contribute ?

@noumendarryl, this question should be asked at the level of the osscameroon website repo. You can create an issue who explain your difficulties to deploy it and you will receive a solution soon.

Copy link
Contributor

@rakici rakici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work, thank you 🥳

@rakici rakici merged commit 4920d4b into osscameroon:main Sep 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants