AO3-5498 AO3-931 Show placeholder for deleted invitee #5000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarken
reviewed
Dec 22, 2024
github-actions
bot
added
Coder Has Actioned Review
and removed
Reviewed: Action Needed
labels
5 tasks
sarken
reviewed
Jan 3, 2025
sarken
reviewed
Jan 3, 2025
config/locales/views/en.yml
Outdated
Comment on lines
1364
to
1365
| deleted_user: deleted user | ||
| deleted_user_with_id: deleted user (%{user_id}) |
There was a problem hiding this comment.
Could you fix the capitalization here? shakes fist at lowercase
|
Oh, hey, this is actually the updated version of the issue you worked on: https://otwarchive.atlassian.net/issues/AO3-5498 Would you like to grab that and finish it off? |
|
Sure! |
brianjaustin
changed the title
sarken
reviewed
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-931 (yes, that's a real ticket number 😅 )
Purpose
When a user sends an invitation, someone accepts it, and then the invitee deletes their account, show the old invitee as a placeholder (suggested by PAC/Support elsewhere):
Side note: the invitation detail page is... a bit confusing as-is. I'm OK using this story to update that if we want, but I haven't done that on my own for a number of reasons.